You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/28 07:41:06 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request, #16838: [fix][broker] Fix misleading -c option in pulsar standalone
RobertIndie opened a new pull request, #16838:
URL: https://github.com/apache/pulsar/pull/16838
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #16800
### Motivation
The -c option offered in the standalone is missleading.
An error occurs when passing --config to the pulsar standalone:
```
2022-07-26T15:11:40,180+0200 [main] ERROR org.apache.pulsar.PulsarStandaloneStarter - Can only specify option -c once.
```
### Modifications
* Add `-Dpulsar.config.file` to specify the pulsar standalone config file
* The priority for config file loading: using `-c or --config` > using `-Dpulsar.config.file`
### Verifying this change
Execute `bin/pulsar standalone` and `bin/pulsar standalone -c {your-config-file}` to verify this change.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #16838: [fix][broker] Fix misleading -c option in pulsar standalone
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on PR #16838:
URL: https://github.com/apache/pulsar/pull/16838#issuecomment-1200111973
> Generally looks good. May I ask why you change `return` to `System.exit`?
This is a bug that I fixed in passing because it will affect this PR: Even after the standalone detects a config file setting error, it does not let the program exit but will continue to run. It doesn't stop until a subsequent error when loading the configuration file.
```
2022-07-30T15:52:28,490+0800 [main] ERROR org.apache.pulsar.PulsarStandaloneStarter - Expected a value after parameter -c
2022-07-30T15:52:28,527+0800 [main] INFO org.apache.pulsar.PulsarStandalone - Found existing ZooKeeper metadata. Continuing with ZooKeeper
2022-07-30T15:52:28,527+0800 [main] ERROR org.apache.pulsar.PulsarStandalone - Failed to load configuration
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16838: [fix][broker] Fix misleading -c option in pulsar standalone
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16838:
URL: https://github.com/apache/pulsar/pull/16838#issuecomment-1200162407
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie merged pull request #16838: [fix][broker] Fix misleading -c option in pulsar standalone
Posted by GitBox <gi...@apache.org>.
RobertIndie merged PR #16838:
URL: https://github.com/apache/pulsar/pull/16838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org