You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/06/19 21:28:48 UTC
[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #228: HTTPCLIENT-2082
ok2c commented on a change in pull request #228:
URL: https://github.com/apache/httpcomponents-client/pull/228#discussion_r443050652
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java
##########
@@ -70,10 +74,13 @@
*/
public class PoolingHttpClientConnectionManagerBuilder {
+ private Lookup<ConnectionSocketFactory> connectionSocketFactoryRegistry;
private HttpConnectionFactory<ManagedHttpClientConnection> connectionFactory;
private LayeredConnectionSocketFactory sslSocketFactory;
private SchemePortResolver schemePortResolver;
private DnsResolver dnsResolver;
+
+ private StrictConnPool<HttpRoute, ManagedHttpClientConnection> managedConnPool;
Review comment:
@rafiek Why do we need this variable? It invalidates `PoolConcurrencyPolicy` parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org