You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/12/09 23:20:17 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-930 Added a strictTran...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/176
TINKERPOP-930 Added a strictTransactionManagement setting to Gremlin Server.
https://issues.apache.org/jira/browse/TINKERPOP-930
Basically forces the user to pass the aliases argument. Gremlin Server then uses that to determine the scope of the transactions to close. This setting is false by default so as to be backward compatible.
Tested with:
```text
mvn clean install
mvn verify -DskipIntegrationTests=false -DincludeNeo4j -pl gremlin-server
```
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-930
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 8b3af12715678543f444f79c314e427019762f5a
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-09T22:17:37Z
Added a strictTransactionManagement setting to Gremlin Server.
Basically forces the user to pass the aliases argument. Gremlin Server then uses that to determine the scope of the transactions to close. This setting is false by default so as to be backward compatible.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-930 Added a strictTran...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/176#issuecomment-164483345
* `mvn clean install` worked
* integration tests worked
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-930 Added a strictTran...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/176#issuecomment-163826091
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-930 Added a strictTran...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---