You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/29 15:03:30 UTC
[GitHub] [dolphinscheduler] krystalics opened a new issue #8264: [Bug] [remote-rpc] The judgment of the asynchronous call callback condition is not accurate
krystalics opened a new issue #8264:
URL: https://github.com/apache/dolphinscheduler/issues/8264
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
env :
macos monterey 12.0.1
java version 1.8.0_241
---
in the [Feature][remote] RPC design #4549 , new module has been add to remote which names rpc. In org.apache.dolphinscheduler.rpc.client.ConsumerInterceptor::cacheServiceConfig
```java
if (!rpc.serviceCallback().isInstance(AbstractRpcCallBack.class)) {
consumerConfig.setCallBack(true);
}
```
In my opinion this judgement wanna find the rpc.serviceCallback()'s class which is extend to AbstractRpcCallBack.class but not AbstractRpcCallBack.class itself. For example the test case --> org.apache.dolphinscheduler.rpc.UserCallback extends AbstractRpcCallBack.
but class.isInstance() is used in a wrong way. it make the callBackIsFalse method callback,but in the origin code it does not set the callback service
```java
public interface IUserService {
@Rpc(async = true, serviceCallback = UserCallback.class)
Boolean say(String s);
Integer hi(int num);
//not set the call back service
@Rpc(async = true)
Boolean callBackIsFalse(String s);
}
```
### What you expected to happen
the right behavior is the method callBackIsFalse() do not trigger the callback!
the right judgement condition is :
```java
if (!AbstractRpcCallBack.class.equals(rpc.serviceCallback()) && AbstractRpcCallBack.class.isAssignableFrom(rpc.serviceCallback())) {
consumerConfig.setCallBack(true);
}
```
### How to reproduce
just run the org.apache.dolphinscheduler.rpc.RpcTest.sendTest(). it can reproduce
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #8264: [Bug] [remote-rpc] The judgment of the asynchronous call callback condition is not accurate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #8264:
URL: https://github.com/apache/dolphinscheduler/issues/8264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #8264: [Bug] [remote-rpc] The judgment of the asynchronous call callback condition is not accurate
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #8264:
URL: https://github.com/apache/dolphinscheduler/issues/8264#issuecomment-1024934225
good job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8264: [Bug] [remote-rpc] The judgment of the asynchronous call callback condition is not accurate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8264:
URL: https://github.com/apache/dolphinscheduler/issues/8264#issuecomment-1054842353
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8264: [Bug] [remote-rpc] The judgment of the asynchronous call callback condition is not accurate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8264:
URL: https://github.com/apache/dolphinscheduler/issues/8264#issuecomment-1062419666
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8264: [Bug] [remote-rpc] The judgment of the asynchronous call callback condition is not accurate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8264:
URL: https://github.com/apache/dolphinscheduler/issues/8264#issuecomment-1024927987
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org