[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4440: Ref #2083: jOOR language native support

["jamesnetherton (via GitHub)" <gi...@apache.org>]

jamesnetherton commented on code in PR #4440:
URL: https://github.com/apache/camel-quarkus/pull/4440#discussion_r1087554562


##########
integration-tests/joor/src/main/resources/META-INF/native-image/reflect-config.json:
##########
@@ -0,0 +1,6 @@
+[
+  {
+    "name" : "org.apache.camel.quarkus.component.joor.it.JoorBean",

Review Comment:
   Nitpick - we could do this with `@RegisterForReflection`.



##########
integration-tests/csimple/src/main/resources/META-INF/native-image/reflect-config.json:
##########
@@ -0,0 +1,6 @@
+[
+  {
+    "name" : "java.lang.String",

Review Comment:
   Nitpick - we could do this with `@RegisterForReflection`.



##########
docs/modules/ROOT/pages/reference/extensions/joor.adoc:
##########
@@ -39,3 +43,39 @@ Please refer to the above link for usage and configuration details.
 ifeval::[{doc-show-user-guide-link} == true]
 Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
 endif::[]
+
+[id="extensions-joor-additional-camel-quarkus-configuration"]
+== Additional Camel Quarkus configuration
+
+The expressions and scripts written using the jOOR language are extracted and compiled at build time, to do so the
+language needs to be instantiated and configured at build time in order to be able to generate the exact same source code as
+the one generated at runtime. For this purpose, the next configuration properties have been added:
+
+
+[width="100%",cols="80,5,15",options="header"]
+|===
+| Configuration property | Type | Default
+
+
+|icon:lock[title=Fixed at build time] [[quarkus.camel.joor.single-quotes]]`link:#quarkus.camel.joor.single-quotes[quarkus.camel.joor.single-quotes]`
+
+Indicates whether a jOOR expression can use single quotes instead of double quotes.
+| `boolean`
+| `true`
+
+|icon:lock[title=Fixed at build time] [[quarkus.camel.joor.config-resource]]`link:#quarkus.camel.joor.config-resource[quarkus.camel.joor.config-resource]`

Review Comment:
   Just an observation - The config descriptions for `config-resource` & `result-type` don't seem to be in the doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org