You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jasonf20 (via GitHub)" <gi...@apache.org> on 2024/08/04 11:32:50 UTC
[PR] S3OutputStream: Don't complete upload on finalize [iceberg]
jasonf20 opened a new pull request, #10874:
URL: https://github.com/apache/iceberg/pull/10874
If a user didn't call close on the stream the file shouldn't be uploaded.
This means that if the user forgets to call `close()` on a completed file it will no longer be uploaded. However, this is preferred to having files which were intentionally not closed being uploaded and creating garbage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Don't complete multipart upload on finalize for S3OutputStream [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #10874:
URL: https://github.com/apache/iceberg/pull/10874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Don't complete upload on finalize for S3OutputStream [iceberg]
Posted by "jasonf20 (via GitHub)" <gi...@apache.org>.
jasonf20 commented on PR #10874:
URL: https://github.com/apache/iceberg/pull/10874#issuecomment-2298237237
@amogh-jahagirdar any way to move this forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Don't complete upload on finalize for S3OutputStream [iceberg]
Posted by "jasonf20 (via GitHub)" <gi...@apache.org>.
jasonf20 commented on PR #10874:
URL: https://github.com/apache/iceberg/pull/10874#issuecomment-2285838414
HI @danielcweeks @jackye1995 would appreciate it if you can take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS: Don't complete multipart upload on finalize for S3OutputStream [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #10874:
URL: https://github.com/apache/iceberg/pull/10874#issuecomment-2299127203
@jasonf20 Thanks for your patience I think we can move forward as is. @Fokko Thank you for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org