You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2024/03/15 08:52:40 UTC
[PR] rft(FQDN): Add some convenient macros and update idl/bulk_load.thrift related code [incubator-pegasus]
acelyc111 opened a new pull request, #1949:
URL: https://github.com/apache/incubator-pegasus/pull/1949
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] refactor(FQDN): Add some convenient macros and update idl/bulk_load.thrift related code [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 merged PR #1949:
URL: https://github.com/apache/incubator-pegasus/pull/1949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] refactor(FQDN): Add some convenient macros and update idl/bulk_load.thrift related code [incubator-pegasus]
Posted by "Smityz (via GitHub)" <gi...@apache.org>.
Smityz commented on code in PR #1949:
URL: https://github.com/apache/incubator-pegasus/pull/1949#discussion_r1565916920
##########
idl/bulk_load.thrift:
##########
@@ -91,7 +91,7 @@ struct bulk_load_request
{
1:dsn.gpid pid;
2:string app_name;
- 3:dsn.rpc_address primary_addr;
+ 3:dsn.rpc_address primary;
Review Comment:
why change this name？could you provide some context message for it？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] refactor(FQDN): Add some convenient macros and update idl/bulk_load.thrift related code [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1949:
URL: https://github.com/apache/incubator-pegasus/pull/1949#discussion_r1566624345
##########
idl/bulk_load.thrift:
##########
@@ -91,7 +91,7 @@ struct bulk_load_request
{
1:dsn.gpid pid;
2:string app_name;
- 3:dsn.rpc_address primary_addr;
+ 3:dsn.rpc_address primary;
Review Comment:
In some newly added macros, they suppose the rpc_address and host_port fields are naming similarly with name `xxx` and `hp_xxx`. The macros are helpful to ensure the operations are taken both on the 2 fields. So I rename it.
Rename the thrift structure fileds dosen't break compatibility if not change the sequence number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org