You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by fe...@apache.org on 2016/04/01 23:58:14 UTC

incubator-zeppelin git commit: remove overwritten style for p

Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 26a2d641c -> 42cccd157


remove overwritten style for p

### What is this PR for?

I don't know why we overwrite `p` in paragraph.css, but the layout is much nicer for markdown paragraphs

### What type of PR is it?

Bug Fix

### Todos

### What is the Jira issue?
[ZEPPELIN-649](https://issues.apache.org/jira/browse/ZEPPELIN-649)

### How should this be tested?

### Screenshots (if appropriate)

Before:
![screen shot 2016-03-28 at 8 58 54 pm](https://cloud.githubusercontent.com/assets/17979200/14097635/f3cf075e-f527-11e5-8acc-edf2e1a877aa.png)

After:
![screen shot 2016-03-28 at 8 58 36 pm](https://cloud.githubusercontent.com/assets/17979200/14097641/f9c72484-f527-11e5-9253-70b423a64ca0.png)

### Questions:
* Does the licenses files need update?
NO

* Is there breaking changes for older versions?
NO

* Does this needs documentation?
NO

Author: johnnyws <jz...@gmail.com>

Closes #797 from johnnyws/seraph/fix-md-paragraph and squashes the following commits:

6578e5f [johnnyws] remove overwritten style for p


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/42cccd15
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/42cccd15
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/42cccd15

Branch: refs/heads/master
Commit: 42cccd15707c1fed992b3c44cf161320e900aec0
Parents: 26a2d64
Author: johnnyws <jz...@gmail.com>
Authored: Thu Mar 24 20:59:22 2016 -0700
Committer: Felix Cheung <fe...@apache.org>
Committed: Fri Apr 1 14:58:07 2016 -0700

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/paragraph/paragraph.css | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/42cccd15/zeppelin-web/src/app/notebook/paragraph/paragraph.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.css b/zeppelin-web/src/app/notebook/paragraph/paragraph.css
index f170ca0..b4873cf 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.css
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.css
@@ -48,10 +48,6 @@
   margin-bottom: 0;
 }
 
-.paragraph p {
-  margin: 0;
-}
-
 .paragraph div svg {
   width: 100%;
 }