You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2024/04/01 13:27:46 UTC
[PR] [SCB-2863]support zookeeper config [servicecomb-java-chassis]
liubao68 opened a new pull request, #4291:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4291
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SCB-2863]support zookeeper config [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #4291:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SCB-2863]support zookeeper config [servicecomb-java-chassis]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4291:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4291#issuecomment-2030929309
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4291?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `75.00000%` with `2 lines` in your changes are missing coverage. Please review.
> Project coverage is 44.93%. Comparing base [(`3b07b6e`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/3b07b6e2afe86be03531695b6071f67bf763437e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6f1ad68`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4291?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: Current head 6f1ad68 differs from pull request most recent head 64c3a8c. Consider uploading reports for the commit 64c3a8c to get more accurate results
| [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4291?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../apache/servicecomb/registry/lightweight/Self.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4291?src=pr&el=tree&filepath=service-registry%2Fregistry-lightweight%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fservicecomb%2Fregistry%2Flightweight%2FSelf.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1saWdodHdlaWdodC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvbGlnaHR3ZWlnaHQvU2VsZi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4291 +/- ##
============================================
+ Coverage 44.87% 44.93% +0.06%
- Complexity 5459 5467 +8
============================================
Files 1386 1386
Lines 34527 34524 -3
Branches 3338 3338
============================================
+ Hits 15493 15514 +21
+ Misses 17782 17757 -25
- Partials 1252 1253 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4291?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org