You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Inder Singh <in...@gmail.com> on 2012/04/09 14:24:59 UTC
Review Request: Issue with HDFSEventSink for append support for
HDFSCompressedDataStream
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4683/
-----------------------------------------------------------
Review request for Flume and Arvind Prabhakar.
Summary
-------
HDFSCompressedDataStream append will fail when append=true and it tries to append to a nonexistent file.
This addresses bug FLUME-1112.
https://issues.apache.org/jira/browse/FLUME-1112
Diffs
-----
trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java 1311206
Diff: https://reviews.apache.org/r/4683/diff
Testing
-------
Ran through the test cases of FLUME.
Thanks,
Inder
Re: Review Request: Issue with HDFSEventSink for append support for
HDFSCompressedDataStream
Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4683/#review6933
-----------------------------------------------------------
+1 looks good to me
- Mike
On 2012-04-09 12:24:59, Inder Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4683/
> -----------------------------------------------------------
>
> (Updated 2012-04-09 12:24:59)
>
>
> Review request for Flume and Arvind Prabhakar.
>
>
> Summary
> -------
>
> HDFSCompressedDataStream append will fail when append=true and it tries to append to a nonexistent file.
>
>
> This addresses bug FLUME-1112.
> https://issues.apache.org/jira/browse/FLUME-1112
>
>
> Diffs
> -----
>
> trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java 1311206
>
> Diff: https://reviews.apache.org/r/4683/diff
>
>
> Testing
> -------
>
> Ran through the test cases of FLUME.
>
>
> Thanks,
>
> Inder
>
>
Re: Review Request: Issue with HDFSEventSink for append support for
HDFSCompressedDataStream
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4683/#review7220
-----------------------------------------------------------
Ship it!
lgtm
- Brock
On 2012-04-09 12:24:59, Inder Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4683/
> -----------------------------------------------------------
>
> (Updated 2012-04-09 12:24:59)
>
>
> Review request for Flume and Arvind Prabhakar.
>
>
> Summary
> -------
>
> HDFSCompressedDataStream append will fail when append=true and it tries to append to a nonexistent file.
>
>
> This addresses bug FLUME-1112.
> https://issues.apache.org/jira/browse/FLUME-1112
>
>
> Diffs
> -----
>
> trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java 1311206
>
> Diff: https://reviews.apache.org/r/4683/diff
>
>
> Testing
> -------
>
> Ran through the test cases of FLUME.
>
>
> Thanks,
>
> Inder
>
>