You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/06 02:51:23 UTC
[GitHub] [pulsar] momo-jun opened a new pull request, #15943: [feature][doc] Add Pulsar Auth support for Pulsar SQL
momo-jun opened a new pull request, #15943:
URL: https://github.com/apache/pulsar/pull/15943
### Motivation
Add docs for the new feature implemented in #15571
### Modifications
1. Add configs to enable and configure Pulsar auth for Pulsar SQL.
2. Minor corrections.
The preview looks good.
<img width="1749" alt="image" src="https://user-images.githubusercontent.com/60642177/172086433-c8453b16-020a-45ac-815b-05e7834ae76d.png">
### Documentation
- [ ] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15943: [feature][doc] Add Pulsar Auth support for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15943:
URL: https://github.com/apache/pulsar/pull/15943#issuecomment-1146980716
@momo-jun:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #15943: [feature][doc] Add Pulsar Auth support for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15943:
URL: https://github.com/apache/pulsar/pull/15943#issuecomment-1146980715
Ping @RobertIndie @Anonymitaet for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15943: [feature][doc] Add Pulsar Auth support for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15943:
URL: https://github.com/apache/pulsar/pull/15943#issuecomment-1146980691
@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #15943: [feature][doc] Add Pulsar Auth support for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15943:
URL: https://github.com/apache/pulsar/pull/15943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15943: [feature][doc] Add Pulsar Auth support for Pulsar SQL
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15943:
URL: https://github.com/apache/pulsar/pull/15943#discussion_r889831732
##########
site2/docs/sql-deployment-configurations.md:
##########
@@ -77,6 +80,9 @@ pulsar.tls-hostname-verification-enable=null
# path for the trusted TLS certificate file of Pulsar broker
pulsar.tls-trust-cert-file-path=null
+## whether to enable pulsar authorization
Review Comment:
```suggestion
## whether to enable Pulsar authorization
```
##########
site2/docs/sql-deployment-configurations.md:
##########
@@ -17,7 +17,10 @@ connector.name=pulsar
# the url of Pulsar broker service
pulsar.web-service-url=http://localhost:8080
-# URI of Zookeeper cluster
+# the url of Pulsar broker binary service
Review Comment:
```suggestion
# the URL of Pulsar broker binary service
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org