You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/19 05:19:12 UTC

[GitHub] [incubator-echarts] xmatthias opened a new pull request #12828: Update comments to not use defualt

xmatthias opened a new pull request #12828:
URL: https://github.com/apache/incubator-echarts/pull/12828


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   Replace typos in comments defining something as "defualt".
   
   
   ### Fixed issues
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Comments had sometimes defualt instead of default (inverting au).
   
   
   ### After: How is it fixed in this PR?
   
   Typos are fixed, replacing defualt with default.
   
   ### Other information
   
   Changes only to comments - code did not show these typos.
   
   
   I hope it's ok to exclude dist (i understand that's only updated by a release?). 
   If not let me know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #12828: Update comments to not use defualt (fixing typo)

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12828:
URL: https://github.com/apache/incubator-echarts/pull/12828


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12828: Update comments to not use defualt (fixing typo)

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12828:
URL: https://github.com/apache/incubator-echarts/pull/12828#issuecomment-646532391


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12828: Update comments to not use defualt

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12828:
URL: https://github.com/apache/incubator-echarts/pull/12828#issuecomment-646440393


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org