[GitHub] spark pull request #15767: [SPARK-18269][SQL] CSV datasource should read nul...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15767#discussion_r86583851
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala ---
    @@ -232,7 +232,7 @@ private[csv] object CSVTypeCast {
           nullable: Boolean = true,
           options: CSVOptions = CSVOptions()): Any = {
     
    -    if (nullable && datum == options.nullValue) {
    +    if (datum == null || nullable && datum == options.nullValue) {
    --- End diff --
    
    This might be clearer with parentheses, though I think it's correct. It is this right?
    `datum == null || (nullable && datum == options.nullValue)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org