[GitHub] r39132 commented on issue #3728: [AIRFLOW-2883] Not search dag owner if owners are missing

[GitBox <gi...@apache.org>]

r39132 commented on issue #3728: [AIRFLOW-2883] Not search dag owner if owners are missing
URL: https://github.com/apache/incubator-airflow/pull/3728#issuecomment-411945258
 
 
   Hi @feng-tao!
   I was not able to reproduce the problem on master, so I'd like some more detail on the bug you encountered.
   
   I tried 3 things:
   1. I created a simple DAG and omitted the owner. When I did this, Airflow defaulted the owner to `Airflow`
   
   2. I created a simple DAg and set the Owner to None. When I did this, the UI crashed, 
   ```
   [2018-08-09 18:04:47,528] ERROR in app: Exception on /admin/ [GET]
   Traceback (most recent call last):
     File "/usr/local/lib/python3.6/site-packages/Flask-0.12.4-py3.6.egg/flask/app.py", line 1982, in wsgi_app
       response = self.full_dispatch_request()
     File "/usr/local/lib/python3.6/site-packages/Flask-0.12.4-py3.6.egg/flask/app.py", line 1614, in full_dispatch_request
       rv = self.handle_user_exception(e)
     File "/usr/local/lib/python3.6/site-packages/Flask-0.12.4-py3.6.egg/flask/app.py", line 1517, in handle_user_exception
       reraise(exc_type, exc_value, tb)
     File "/usr/local/lib/python3.6/site-packages/Flask-0.12.4-py3.6.egg/flask/_compat.py", line 33, in reraise
       raise value
     File "/usr/local/lib/python3.6/site-packages/Flask-0.12.4-py3.6.egg/flask/app.py", line 1612, in full_dispatch_request
       rv = self.dispatch_request()
     File "/usr/local/lib/python3.6/site-packages/Flask-0.12.4-py3.6.egg/flask/app.py", line 1598, in dispatch_request
       return self.view_functions[rule.endpoint](**req.view_args)
     File "/usr/local/lib/python3.6/site-packages/Flask_Admin-1.4.1-py3.6.egg/flask_admin/base.py", line 69, in inner
       return self._run_view(f, *args, **kwargs)
     File "/usr/local/lib/python3.6/site-packages/Flask_Admin-1.4.1-py3.6.egg/flask_admin/base.py", line 368, in _run_view
       return fn(self, *args, **kwargs)
     File "/usr/local/lib/python3.6/site-packages/Flask_Login-0.2.11-py3.6.egg/flask_login.py", line 755, in decorated_view
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.6/site-packages/airflow/utils/db.py", line 74, in wrapper
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.6/site-packages/airflow/www/views.py", line 2040, in index
       auto_complete_data.add(dag.owner)
     File "/usr/local/lib/python3.6/site-packages/airflow/models.py", line 3506, in owner
       return ", ".join(list(set([t.owner for t in self.tasks])))
   ```
   
   3. I set owner to the empty string: ''
   This worked fine. The UI was able to support my searching for other owners and my dag was excluded. If clear the search box and execute a search, then I get all DAGs back, including my sample DAG.
   
   What test case am I missing here and what did you run into? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services