You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/30 06:41:41 UTC
[GitHub] [incubator-dolphinscheduler] amorynan opened a new pull request
#1639: Upstream/feature ut common thread
amorynan opened a new pull request #1639: Upstream/feature ut common thread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1639
This change added tests and can be verified as follows:
and this is the ut cover show in common thread package
- *Added apache license in the test file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] amorynan commented on issue #1639:
Upstream/feature ut common thread
Posted by GitBox <gi...@apache.org>.
amorynan commented on issue #1639: Upstream/feature ut common thread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1639#issuecomment-570112253
already add it to pom.xml ,please check it ...thx
------------------ 原始邮件 ------------------
发件人: "dailidong"<notifications@github.com>;
发送时间: 2020年1月1日(星期三) 晚上9:25
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "日光"<2421902248@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Upstream/feature ut common thread (#1639)
you should add this file in pom.xml, then it can be run in ut
good advice
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] khadgarmage merged pull request #1639:
Upstream/feature ut common thread
Posted by GitBox <gi...@apache.org>.
khadgarmage merged pull request #1639: Upstream/feature ut common thread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1639:
Upstream/feature ut common thread
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1639: Upstream/feature ut common thread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1639#issuecomment-570052989
> you should add this file in pom.xml, then it can be run in ut
good advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1639:
Upstream/feature ut common thread
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1639: Upstream/feature ut common thread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1639#issuecomment-569597412
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1639?src=pr&el=h1) Report
> Merging [#1639](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1639?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/6d4a3410c86feed171063b760aa4b504662c75a2?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1639?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1639 +/- ##
=====================================
Coverage 8.11% 8.11%
=====================================
Files 282 282
Lines 13924 13924
Branches 2254 2254
=====================================
Hits 1130 1130
Misses 12676 12676
Partials 118 118
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1639?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1639?src=pr&el=footer). Last update [6d4a341...56db53a](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1639?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services