You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Vamsi-klu (via GitHub)" <gi...@apache.org> on 2026/09/12 00:31:56 UTC
[PR] Parse V2 LLC segment names without writing them [pinot]
Vamsi-klu opened a new pull request, #19531:
URL: https://github.com/apache/pinot/pull/19531
This is the parse-only slice of #17260. Readers can recognize `table__v2__topicId__partitionId__sequence__creationTime` names. Generation stays on the existing 4-part V1 constructor. No V2 names are written.
Not stacked on #18830, #18913, or #18949. Those PRs write a 5-part name or keep packed ints. This one only teaches `LLCSegmentName` and a new `StreamPartitionIdentity` type to read the 6-token `v2` grammar.
## What changed
- `LLCSegmentName` accepts V1 (4 tokens) and V2 (6 tokens, literal `v2`).
- `isLLCSegment`, `of`, and `getSequenceNumber(String)` handle both.
- `getPartitionGroupId()` stays an `int` and is V1-only (throws on V2), per Jackie on #18913.
- New accessors: `getFormatVersion()`, `getTopicId()`, `getPartitionId()`, `getStreamPartitionIdentity()`.
- `StreamPartitionIdentity` in `pinot-spi`. No `topicId * 10000` helpers.
- Uploaded 5-part names and the #18830 5-part grammar stay non-LLC.
- `IngestionConfigUtils` packing is unchanged.
`formatV2` is package-private for tests. Production writers still use the 4-arg V1 constructor.
## Validation
```
./mvnw -pl pinot-common,pinot-spi -am \
-Dtest=LLCSegmentNameTest,StreamPartitionIdentityTest \
-Dsurefire.failIfNoSpecifiedTests=false test
```
13 tests passed. Spotless, checkstyle, and license checks passed on `pinot-spi` and `pinot-common`.
Base: apache/master `26bf075d16` after rebase.
Label: `bugfix` (template requirement).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Parse V2 LLC segment names without writing them [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19531:
URL: https://github.com/apache/pinot/pull/19531#issuecomment-5642482817
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19531?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `94.04762%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.83%. Comparing base ([`26bf075`](https://app.codecov.io/gh/apache/pinot/commit/26bf075d16cfc6d80d5682589109f873a9c6dd96?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`181cfd2`](https://app.codecov.io/gh/apache/pinot/commit/181cfd20a3df77f1f690a119b3391c28da8c22f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/19531?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/pinot/spi/stream/StreamPartitionIdentity.java](https://app.codecov.io/gh/apache/pinot/pull/19531?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Fstream%2FStreamPartitionIdentity.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbVBhcnRpdGlvbklkZW50aXR5LmphdmE=) | 85.29% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/19531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (26bf075) and HEAD (181cfd2). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (26bf075) | HEAD (181cfd2) |
>|------|------|------|
>|unittests2|1|0|
>|unittests|2|1|
>|java-25|6|1|
>|temurin|6|1|
>|lane-a|2|0|
>|integration|4|0|
>|integration2|2|0|
>|lane-b|2|0|
>|integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19531 +/- ##
============================================
- Coverage 67.71% 57.83% -9.88%
+ Complexity 1450 1 -1449
============================================
Files 3490 2686 -804
Lines 225023 164423 -60600
Branches 35525 26694 -8831
============================================
- Hits 152374 95102 -57272
- Misses 60631 61292 +661
+ Partials 12018 8029 -3989
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.83% <94.04%> (-9.88%)` | :arrow_down: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.83% <94.04%> (-9.88%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.83% <94.04%> (-9.88%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.83% <94.04%> (-0.01%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19531?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Parse V2 LLC segment names without writing them [pinot]
Posted by "rseetham (via GitHub)" <gi...@apache.org>.
rseetham commented on PR #19531:
URL: https://github.com/apache/pinot/pull/19531#issuecomment-5796551878
> We don't want to introduce `v2` into the segment name.
> @rseetham Are you still working on #18913?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Parse V2 LLC segment names without writing them [pinot]
Posted by "Vamsi-klu (via GitHub)" <gi...@apache.org>.
Vamsi-klu commented on PR #19531:
URL: https://github.com/apache/pinot/pull/19531#issuecomment-5642194470
cc @Jackie-Jiang @xiangfu0 parse-only, no V2 writes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Parse V2 LLC segment names without writing them [pinot]
Posted by "Vamsi-klu (via GitHub)" <gi...@apache.org>.
Vamsi-klu closed pull request #19531: Parse V2 LLC segment names without writing them
URL: https://github.com/apache/pinot/pull/19531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org