You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/09/09 23:33:57 UTC

[kudu-CR] [WIP] KUDU-1261 Java client complex type introduction

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 )

Change subject: [WIP] KUDU-1261 Java client complex type introduction
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20749/7/src/kudu/common/common.proto
File src/kudu/common/common.proto:

http://gerrit.cloudera.org:8080/#/c/20749/7/src/kudu/common/common.proto@107
PS7, Line 107:   // If the column is an array
             :   optional bool is_array = 1;
> If this already named as 'ArrayColumnAttributesPB', then why to introduce '
Yes, it is not absolutely needed but I just left it there in case we ever need it as there is more work(server side) to be done before we can finalize the client API.



-- 
To view, visit http://gerrit.cloudera.org:8080/20749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92825c4ab430ccd4bbd902b06679488af91d9804
Gerrit-Change-Number: 20749
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Sep 2024 23:33:57 +0000
Gerrit-HasComments: Yes