You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "lijay7674 (via GitHub)" <gi...@apache.org> on 2023/05/04 08:35:59 UTC
[GitHub] [shenyu] lijay7674 opened a new pull request, #4610: Add test cases for service.manager.impl
lijay7674 opened a new pull request, #4610:
URL: https://github.com/apache/shenyu/pull/4610
<!-- Describe your PR here; eg. Fixes #4540 -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [√ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [√ ] You submit test cases (unit or integration tests) that back your changes.
- [ √] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 commented on pull request #4610: Add test cases for service.manager.impl
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 commented on PR #4610:
URL: https://github.com/apache/shenyu/pull/4610#issuecomment-1535823092
hi， pls checked checkstyle and build in you local env.
> so much checkstyle error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 commented on pull request #4610: Add test cases for service.manager.impl
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 commented on PR #4610:
URL: https://github.com/apache/shenyu/pull/4610#issuecomment-1539815634
@lijay7674 you can add my wechat: xixy199195, i wiil invite you join contributor group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 commented on pull request #4610: Add test cases for service.manager.impl
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 commented on PR #4610:
URL: https://github.com/apache/shenyu/pull/4610#issuecomment-1537097170
@lijay7674 hi， can you updata master to you dev，then summit pull request ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4610: Add test cases for service.manager.impl
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4610:
URL: https://github.com/apache/shenyu/pull/4610#issuecomment-1537038877
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4610](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6a4129) into [master](https://app.codecov.io/gh/apache/shenyu/commit/d6067f4bce8033f93fd6268cf2da36553ec3eb22?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6067f4) will **increase** coverage by `0.56%`.
> The diff coverage is `62.75%`.
```diff
@@ Coverage Diff @@
## master #4610 +/- ##
============================================
+ Coverage 67.62% 68.18% +0.56%
- Complexity 7845 7919 +74
============================================
Files 1070 1078 +8
Lines 30650 30775 +125
Branches 2790 2807 +17
============================================
+ Hits 20726 20983 +257
+ Misses 8303 8139 -164
- Partials 1621 1653 +32
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/shenyu/plugin/base/fallback/FallbackHandler.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9mYWxsYmFjay9GYWxsYmFja0hhbmRsZXIuamF2YQ==) | `36.84% <0.00%> (-17.01%)` | :arrow_down: |
| [.../apache/shenyu/plugin/hystrix/command/Command.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9jb21tYW5kL0NvbW1hbmQuamF2YQ==) | `7.69% <0.00%> (+2.69%)` | :arrow_up: |
| [.../shenyu/plugin/hystrix/command/HystrixCommand.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9jb21tYW5kL0h5c3RyaXhDb21tYW5kLmphdmE=) | `55.55% <0.00%> (ø)` | |
| [...plugin/hystrix/command/HystrixCommandOnThread.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9jb21tYW5kL0h5c3RyaXhDb21tYW5kT25UaHJlYWQuamF2YQ==) | `61.11% <0.00%> (ø)` | |
| [.../springmvc/ShenyuSpringMvcClientConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zcHJpbmdib290L3N0YXJ0ZXIvY2xpZW50L3NwcmluZ212Yy9TaGVueXVTcHJpbmdNdmNDbGllbnRDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyuSpringMvcClientInfoRegisterConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zcHJpbmdib290L3N0YXJ0ZXIvY2xpZW50L3NwcmluZ212Yy9TaGVueXVTcHJpbmdNdmNDbGllbnRJbmZvUmVnaXN0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pringboot/starter/gateway/ShenyuConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItZ2F0ZXdheS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9nYXRld2F5L1NoZW55dUNvbmZpZ3VyYXRpb24uamF2YQ==) | `88.00% <0.00%> (-3.67%)` | :arrow_down: |
| [...shenyu/web/fallback/DefaultFallbackController.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9mYWxsYmFjay9EZWZhdWx0RmFsbGJhY2tDb250cm9sbGVyLmphdmE=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...pache/shenyu/web/filter/CollapseSlashesFilter.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9maWx0ZXIvQ29sbGFwc2VTbGFzaGVzRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/shenyu/web/filter/HealthFilter.java](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9maWx0ZXIvSGVhbHRoRmlsdGVyLmphdmE=) | `62.50% <60.00%> (-37.50%)` | :arrow_down: |
| ... and [6 more](https://app.codecov.io/gh/apache/shenyu/pull/4610?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4610/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] lijay7674 commented on pull request #4610: Add test cases for service.manager.impl
Posted by "lijay7674 (via GitHub)" <gi...@apache.org>.
lijay7674 commented on PR #4610:
URL: https://github.com/apache/shenyu/pull/4610#issuecomment-1538051701
> not merged
sorry,Can I initiate a new pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 commented on pull request #4610: Add test cases for service.manager.impl
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 commented on PR #4610:
URL: https://github.com/apache/shenyu/pull/4610#issuecomment-1538111741
src/test/java/org/apache/shenyu/admin/service/manager/impl/LoadServiceDocEntryImplTest.java:[99] (sizes) LineLength: Line is longer than 200 characters (found 208).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] lijay7674 commented on pull request #4610: Add test cases for service.manager.impl
Posted by "lijay7674 (via GitHub)" <gi...@apache.org>.
lijay7674 commented on PR #4610:
URL: https://github.com/apache/shenyu/pull/4610#issuecomment-1536278057
> hi， pls checked checkstyle and build in you local env.
>
> > so much checkstyle error
thx，After this inspection, I learned a lot and found my own shortcomings. At present, I have made a modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #4610: Add test cases for service.manager.impl
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 merged PR #4610:
URL: https://github.com/apache/shenyu/pull/4610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org