[GitHub] [ozone] adoroszlai commented on a diff in pull request #4725: HDDS-8639. Clean up OzoneOutputStream and the related code.

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #4725:
URL: https://github.com/apache/ozone/pull/4725#discussion_r1197661630


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2175,8 +2142,9 @@ private OzoneInputStream createInputStream(
     }
   }
   private OzoneDataStreamOutput createDataStreamOutput(OpenKeySession openKey,
-      String requestId, ReplicationConfig replicationConfig)
-      throws IOException {
+      String requestId) throws IOException {

Review Comment:
   Nit: actual value of `requestId` is `UUID.randomUUID().toString()` in both calls, so we could convert it to a local variable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org