[incubator-druid] branch master updated: ParallelIndexSupervisorTask: don't warn about a default value (#6987)

[ji...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jihoonson pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 7e48593  ParallelIndexSupervisorTask: don't warn about a default value (#6987)
7e48593 is described below

commit 7e48593b5780c3bc4852d183dc473be283c84d25
Author: David Glasser <gl...@apollographql.com>
AuthorDate: Mon Feb 4 12:00:26 2019 -0800

    ParallelIndexSupervisorTask: don't warn about a default value (#6987)
    
    Native batch indexing doesn't yet support the maxParseExceptions,
    maxSavedParseExceptions, and logParseExceptions tuning config options, so
    ParallelIndexSupervisorTask logs if these are set. But the default value for
    maxParseExceptions is Integer.MAX_VALUE, which means that you'll get the
    maxParseExceptions flavor of this warning even if you don't configure
    maxParseExceptions.
    
    This PR changes all three warnings to occur if you change the settings from the
    default; this mostly affects the maxParseExceptions warning.
---
 .../common/task/batch/parallel/ParallelIndexSupervisorTask.java   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
index b8a2309..385797f 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
@@ -48,6 +48,7 @@ import org.apache.druid.indexing.common.task.batch.parallel.ParallelIndexTaskRun
 import org.apache.druid.java.util.common.IAE;
 import org.apache.druid.java.util.common.ISE;
 import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.segment.indexing.TuningConfig;
 import org.apache.druid.segment.indexing.granularity.GranularitySpec;
 import org.apache.druid.segment.realtime.appenderator.SegmentIdWithShardSpec;
 import org.apache.druid.segment.realtime.firehose.ChatHandler;
@@ -140,13 +141,14 @@ public class ParallelIndexSupervisorTask extends AbstractTask implements ChatHan
     this.authorizerMapper = authorizerMapper;
     this.rowIngestionMetersFactory = rowIngestionMetersFactory;
 
-    if (ingestionSchema.getTuningConfig().getMaxSavedParseExceptions() > 0) {
+    if (ingestionSchema.getTuningConfig().getMaxSavedParseExceptions()
+        != TuningConfig.DEFAULT_MAX_SAVED_PARSE_EXCEPTIONS) {
       log.warn("maxSavedParseExceptions is not supported yet");
     }
-    if (ingestionSchema.getTuningConfig().getMaxParseExceptions() > 0) {
+    if (ingestionSchema.getTuningConfig().getMaxParseExceptions() != TuningConfig.DEFAULT_MAX_PARSE_EXCEPTIONS) {
       log.warn("maxParseExceptions is not supported yet");
     }
-    if (ingestionSchema.getTuningConfig().isLogParseExceptions()) {
+    if (ingestionSchema.getTuningConfig().isLogParseExceptions() != TuningConfig.DEFAULT_LOG_PARSE_EXCEPTIONS) {
       log.warn("logParseExceptions is not supported yet");
     }
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org