You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by sohami <gi...@git.apache.org> on 2018/02/03 19:30:05 UTC

[GitHub] drill pull request #1109: DRILL-6128: Wrong Result with Nested Loop Join

GitHub user sohami opened a pull request:

    https://github.com/apache/drill/pull/1109

    DRILL-6128: Wrong Result with Nested Loop Join

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sohami/drill DRILL-6128

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1109
    
----
commit 4e776e21e77a53e3f4c831f5afcceed90adf15f2
Author: Sorabh Hamirwasia <sh...@...>
Date:   2018-02-03T02:52:38Z

    DRILL-6128: Wrong Result with Nested Loop Join

----


---

[GitHub] drill issue #1109: DRILL-6128: Wrong Result with Nested Loop Join

Posted by sohami <gi...@git.apache.org>.

Github user sohami commented on the issue:

    https://github.com/apache/drill/pull/1109
  
    @amansinha100 - Please help to review.


---

[GitHub] drill issue #1109: DRILL-6128: Wrong Result with Nested Loop Join

Posted by amansinha100 <gi...@git.apache.org>.

Github user amansinha100 commented on the issue:

    https://github.com/apache/drill/pull/1109
  
    +1 .  Thanks for adding the unit tests. 


---

[GitHub] drill pull request #1109: DRILL-6128: Wrong Result with Nested Loop Join

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1109


---

[GitHub] drill issue #1109: DRILL-6128: Wrong Result with Nested Loop Join

Posted by sohami <gi...@git.apache.org>.

Github user sohami commented on the issue:

    https://github.com/apache/drill/pull/1109
  
    Updated the comment and rebased on top of latest master


---

[GitHub] drill pull request #1109: DRILL-6128: Wrong Result with Nested Loop Join

Posted by amansinha100 <gi...@git.apache.org>.

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1109#discussion_r166981670
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinTemplate.java ---
    @@ -117,9 +117,12 @@ private int populateOutgoingBatch(JoinRelType joinType, int outputIndex) {
           for (; nextRightBatchToProcess < rightCounts.size(); nextRightBatchToProcess++) {
             int rightRecordCount = rightCounts.get(nextRightBatchToProcess);
             // for every record in right batch
    +        final int currentRightBatchIndex = nextRightBatchToProcess << 16;
             for (; nextRightRecordToProcess < rightRecordCount; nextRightRecordToProcess++) {
     
    -          if (doEval(nextLeftRecordToProcess, nextRightBatchToProcess, nextRightRecordToProcess)) {
    +          // Since right container is a hyper container, in doEval generated code it expects the
    --- End diff --
    
    Minor: this comment ideally could be moved up to the statement where you do the left shift since that's the main change. 


---