You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/26 17:07:09 UTC

[GitHub] [phoenix] virajjasani edited a comment on pull request #982: PHOENIX-6082 : Avoid checkAndPut when altering properties for a table or view with column-encoding enabled

virajjasani edited a comment on pull request #982:
URL: https://github.com/apache/phoenix/pull/982#issuecomment-734405590


   > Can you please confirm this patch locally by scanning SYSTEM.MUTEX via HBase shell?
   
   Sure, confirmed by scanning SYSTEM.MUTEX on local cluster with and without this patch.
   
   Initially, updated SYSTEM.MUTEX with KEEP_DELETED_CELLS => 'TRUE' because while executing ALTER TABLE query, Mutex cell is going to be deleted soon (finally block), hence it appears only momentarily.
   
   <img width="1784" alt="Screenshot 2020-11-26 at 10 26 59 PM" src="https://user-images.githubusercontent.com/34790606/100377021-86a10980-3036-11eb-8929-4c0ef2cd3453.png">
   
   
   With patch, no records were found while scanning SYSTEM.MUTEX:
   
   <img width="616" alt="Screenshot 2020-11-26 at 10 10 42 PM" src="https://user-images.githubusercontent.com/34790606/100376799-24480900-3036-11eb-99fe-6c9d5a39b05e.png">
   
   
   Without patch, executed ALTER TABLE query twice and found two deleted rows (first scan result after first execution of ALTER query, and second scan result after second execution of ALTER query) :
   
   <img width="1019" alt="Screenshot 2020-11-26 at 10 35 41 PM" src="https://user-images.githubusercontent.com/34790606/100377718-c3b9cb80-3037-11eb-88e9-ddc9d1ad6c04.png">
   
   
   ALTER TABLE query used for testing:
   
   <img width="594" alt="Screenshot 2020-11-26 at 10 27 51 PM" src="https://user-images.githubusercontent.com/34790606/100377137-b6501180-3036-11eb-913f-189edf7ce599.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org