You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2010/03/15 18:26:16 UTC
svn commit: r923347 - /maven/archetype/trunk/pom.xml
Author: hboutemy
Date: Mon Mar 15 17:26:16 2010
New Revision: 923347
URL: http://svn.apache.org/viewvc?rev=923347&view=rev
Log:
use ${project.version} for internal artifacts to avoid copy/paste
Modified:
maven/archetype/trunk/pom.xml
Modified: maven/archetype/trunk/pom.xml
URL: http://svn.apache.org/viewvc/maven/archetype/trunk/pom.xml?rev=923347&r1=923346&r2=923347&view=diff
==============================================================================
--- maven/archetype/trunk/pom.xml (original)
+++ maven/archetype/trunk/pom.xml Mon Mar 15 17:26:16 2010
@@ -64,7 +64,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.archetype</groupId>
<artifactId>archetype-common</artifactId>
- <version>2.0-alpha-5-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
Re: svn commit: r923347 - /maven/archetype/trunk/pom.xml
Posted by Stephen Connolly <st...@gmail.com>.
well if they are in the same reactor when the release plugin runs,
then the release plugin will update them too.
i thought the preferred way for specifying dependency versions within
the release reactor was to just list the version... though the release
plugin will work with ${project.version}
if you are specifying a version of deps outside the release reactor,
then you shouldn't use project.version as if your release goes bad and
you need to roll again, you force a release of your dependents
but I was just asking what the recommended is, the above was what I
thought the recommended is
Sent from my [rhymes with tryPod] ;-)
On 16 Mar 2010, at 22:28, Hervé BOUTEMY <he...@free.fr> wrote:
> I didn't know this one: how can release plugin know that another
> artifact
> version should be kept in sync with current one?
> I took this pattern in Maven 3 trunk and found it quite good.
>
> I'm interested in any feeed back
>
> Le mardi 16 mars 2010, Stephen Connolly a écrit :
>> I thought best practice was to leave the version as is and let maven
>> release plugin update it for you?
>>
>> On 15 March 2010 17:26, <hb...@apache.org> wrote:
>>> Author: hboutemy
>>> Date: Mon Mar 15 17:26:16 2010
>>> New Revision: 923347
>>>
>>> URL: http://svn.apache.org/viewvc?rev=923347&view=rev
>>> Log:
>>> use ${project.version} for internal artifacts to avoid copy/paste
>>>
>>> Modified:
>>> maven/archetype/trunk/pom.xml
>>>
>>> Modified: maven/archetype/trunk/pom.xml
>>> URL:
>>> http://svn.apache.org/viewvc/maven/archetype/trunk/pom.xml?rev=923347&r1=
>>> 923346&r2=923347&view=diff
>>>
>>> ===
>>> ===
>>> ===================================================================
>>> ===== --- maven/archetype/trunk/pom.xml (original)
>>> +++ maven/archetype/trunk/pom.xml Mon Mar 15 17:26:16 2010
>>> @@ -64,7 +64,7 @@ under the License.
>>> <dependency>
>>> <groupId>org.apache.maven.archetype</groupId>
>>> <artifactId>archetype-common</artifactId>
>>> - <version>2.0-alpha-5-SNAPSHOT</version>
>>> + <version>${project.version}</version>
>>> </dependency>
>>> <dependency>
>>> <groupId>org.apache.maven</groupId>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r923347 - /maven/archetype/trunk/pom.xml
Posted by Brett Porter <br...@apache.org>.
It's for when you release them together, it will match up the versions and replace them. Either approach works.
I think your change is good, ${project.version} is preferable. It both indicates to the reader that "it's the same as the current project and that's important", as well as causing fewer changes during the release process.
- Brett
On 17/03/2010, at 9:28 AM, Hervé BOUTEMY wrote:
> I didn't know this one: how can release plugin know that another artifact
> version should be kept in sync with current one?
> I took this pattern in Maven 3 trunk and found it quite good.
>
> I'm interested in any feeed back
>
> Le mardi 16 mars 2010, Stephen Connolly a écrit :
>> I thought best practice was to leave the version as is and let maven
>> release plugin update it for you?
>>
>> On 15 March 2010 17:26, <hb...@apache.org> wrote:
>>> Author: hboutemy
>>> Date: Mon Mar 15 17:26:16 2010
>>> New Revision: 923347
>>>
>>> URL: http://svn.apache.org/viewvc?rev=923347&view=rev
>>> Log:
>>> use ${project.version} for internal artifacts to avoid copy/paste
>>>
>>> Modified:
>>> maven/archetype/trunk/pom.xml
>>>
>>> Modified: maven/archetype/trunk/pom.xml
>>> URL:
>>> http://svn.apache.org/viewvc/maven/archetype/trunk/pom.xml?rev=923347&r1=
>>> 923346&r2=923347&view=diff
>>>
>>> =========================================================================
>>> ===== --- maven/archetype/trunk/pom.xml (original)
>>> +++ maven/archetype/trunk/pom.xml Mon Mar 15 17:26:16 2010
>>> @@ -64,7 +64,7 @@ under the License.
>>> <dependency>
>>> <groupId>org.apache.maven.archetype</groupId>
>>> <artifactId>archetype-common</artifactId>
>>> - <version>2.0-alpha-5-SNAPSHOT</version>
>>> + <version>${project.version}</version>
>>> </dependency>
>>> <dependency>
>>> <groupId>org.apache.maven</groupId>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r923347 - /maven/archetype/trunk/pom.xml
Posted by Hervé BOUTEMY <he...@free.fr>.
I didn't know this one: how can release plugin know that another artifact
version should be kept in sync with current one?
I took this pattern in Maven 3 trunk and found it quite good.
I'm interested in any feeed back
Le mardi 16 mars 2010, Stephen Connolly a écrit :
> I thought best practice was to leave the version as is and let maven
> release plugin update it for you?
>
> On 15 March 2010 17:26, <hb...@apache.org> wrote:
> > Author: hboutemy
> > Date: Mon Mar 15 17:26:16 2010
> > New Revision: 923347
> >
> > URL: http://svn.apache.org/viewvc?rev=923347&view=rev
> > Log:
> > use ${project.version} for internal artifacts to avoid copy/paste
> >
> > Modified:
> > maven/archetype/trunk/pom.xml
> >
> > Modified: maven/archetype/trunk/pom.xml
> > URL:
> > http://svn.apache.org/viewvc/maven/archetype/trunk/pom.xml?rev=923347&r1=
> >923346&r2=923347&view=diff
> >
> > =========================================================================
> >===== --- maven/archetype/trunk/pom.xml (original)
> > +++ maven/archetype/trunk/pom.xml Mon Mar 15 17:26:16 2010
> > @@ -64,7 +64,7 @@ under the License.
> > <dependency>
> > <groupId>org.apache.maven.archetype</groupId>
> > <artifactId>archetype-common</artifactId>
> > - <version>2.0-alpha-5-SNAPSHOT</version>
> > + <version>${project.version}</version>
> > </dependency>
> > <dependency>
> > <groupId>org.apache.maven</groupId>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r923347 - /maven/archetype/trunk/pom.xml
Posted by Stephen Connolly <st...@gmail.com>.
I thought best practice was to leave the version as is and let maven release
plugin update it for you?
On 15 March 2010 17:26, <hb...@apache.org> wrote:
> Author: hboutemy
> Date: Mon Mar 15 17:26:16 2010
> New Revision: 923347
>
> URL: http://svn.apache.org/viewvc?rev=923347&view=rev
> Log:
> use ${project.version} for internal artifacts to avoid copy/paste
>
> Modified:
> maven/archetype/trunk/pom.xml
>
> Modified: maven/archetype/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/maven/archetype/trunk/pom.xml?rev=923347&r1=923346&r2=923347&view=diff
>
> ==============================================================================
> --- maven/archetype/trunk/pom.xml (original)
> +++ maven/archetype/trunk/pom.xml Mon Mar 15 17:26:16 2010
> @@ -64,7 +64,7 @@ under the License.
> <dependency>
> <groupId>org.apache.maven.archetype</groupId>
> <artifactId>archetype-common</artifactId>
> - <version>2.0-alpha-5-SNAPSHOT</version>
> + <version>${project.version}</version>
> </dependency>
> <dependency>
> <groupId>org.apache.maven</groupId>
>
>
>