Re: Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.

[Sachchidanand Vaidya <va...@juniper.net>]

> On Nov. 25, 2013, 8:01 a.m., Hugo Trippaers wrote:
> >

I have made changes to fix all the review comments. What is the procedure to upload this diff. Do I upload the complete diff or only diff for revirw comments ?

Thanks,
Sachin


- Sachchidanand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15825/#review29367
-----------------------------------------------------------


On Nov. 24, 2013, 6:59 p.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15825/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 6:59 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The code change adds UnitTest cases for Juniper Contrail Virtual Network(VN) and Virtual Machine(VM) Model classes.
> Only VN & VM creation test cases added. 
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java 7f66a3b 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java 32d5d93 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualMachineModelTest.java PRE-CREATION 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java 0938541 
> 
> Diff: https://reviews.apache.org/r/15825/diff/
> 
> 
> Testing
> -------
> 
> Juniper contrail Unit Tests ran successfully as part of package build.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>