You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/17 01:31:48 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26907: [SPARK-30267][SQL] Avro arrays can be of any List

HyukjinKwon commented on a change in pull request #26907: [SPARK-30267][SQL] Avro arrays can be of any List
URL: https://github.com/apache/spark/pull/26907#discussion_r358557382
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala
 ##########
 @@ -167,7 +167,7 @@ class AvroDeserializer(rootAvroType: Schema, rootCatalystType: DataType) {
       case (ARRAY, ArrayType(elementType, containsNull)) =>
         val elementWriter = newWriter(avroType.getElementType, elementType, path)
         (updater, ordinal, value) =>
-          val array = value.asInstanceOf[GenericData.Array[Any]]
+          val array = value.asInstanceOf[java.util.List[Any]]
 
 Review comment:
   Can you add a test? in which case it becomes a regular list?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org