You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/23 01:00:42 UTC

[GitHub] [nifi] stanislav-antufeev opened a new pull request #4837: NIFI-6113 Refactoring to remove instance level variable to make it stateless

stanislav-antufeev opened a new pull request #4837:
URL: https://github.com/apache/nifi/pull/4837


   Refactoring to remove instance level variable to make it stateless.
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   fixes bug NIFI-6113, refactoring
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] turcsanyip commented on a change in pull request #4837: NIFI-6113 Refactoring to remove instance level variable to make it stateless

Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #4837:
URL: https://github.com/apache/nifi/pull/4837#discussion_r581422845



##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
##########
@@ -707,24 +642,24 @@ void finish(ProcessSession session) {
     /*
      * Keeps all request details in single object.
      */
-    static class HDFSFileInfoRequest{
-        enum Groupping {
+    static class HDFSFileInfoRequest {
+        protected enum Grouping {

Review comment:
       As the enclosing class is `package private`, I don't think `protected` really makes sense here. I believe the original was fine. Or do I miss something?

##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
##########
@@ -264,8 +263,6 @@ protected void init(final ProcessorInitializationContext context) {
     @Override
     public void onPropertyModified(PropertyDescriptor descriptor, String oldValue, String newValue) {

Review comment:
       This method can be deleted now because it does not do anything just calls the super.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #4837: NIFI-6113 Refactoring to remove instance level variable to make it stateless

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4837:
URL: https://github.com/apache/nifi/pull/4837


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] stanislav-antufeev commented on pull request #4837: NIFI-6113 Refactoring to remove instance level variable to make it stateless

Posted by GitBox <gi...@apache.org>.
stanislav-antufeev commented on pull request #4837:
URL: https://github.com/apache/nifi/pull/4837#issuecomment-784700878


   @turcsanyip looks like i don't have enough pemissions on https://issues.apache.org to assign the ticket to me.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] pvillard31 commented on pull request #4837: NIFI-6113 Refactoring to remove instance level variable to make it stateless

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4837:
URL: https://github.com/apache/nifi/pull/4837#issuecomment-784741212


   @stanislav-antufeev - I added you as a contributor on JIRA and assigned the JIRA to you. You should have enough permissions going forward. Thanks for your contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] stanislav-antufeev commented on pull request #4837: NIFI-6113 Refactoring to remove instance level variable to make it stateless

Posted by GitBox <gi...@apache.org>.
stanislav-antufeev commented on pull request #4837:
URL: https://github.com/apache/nifi/pull/4837#issuecomment-784237466


   Hello Nifi Community. Can someone review and merge my changes to main Nifi branch.
   This issue is upvoted and the fix needs to be included into next release.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org