You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/15 09:40:00 UTC
[jira] [Commented] (TOMEE-2155) Upgrade HSQLDB to >= 2.3.3 to fix
2.3.2 regression
[ https://issues.apache.org/jira/browse/TOMEE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292255#comment-16292255 ]
ASF GitHub Bot commented on TOMEE-2155:
---------------------------------------
GitHub user kakawait opened a pull request:
https://github.com/apache/tomee/pull/116
Upgrade HSQLDB to 2.3.5
HSQLDB 2.3.2 has regression that prevent:
> multiple rows with partial null values could not be inserted in UNIQUE indexes
See http://hsqldb.org/doc/2.0/changelist_2_0.txt 2.3.3 CHANGE_LOG
I would update to latest JRE 6 compatible HSQLDB version (except 2.4.0 that is required JRE 8)
Fixes TOMEE-2155
---
I was not able to run `mvn clean install` completely... I always get a fail on (even on unmodified `master` branch)
```
[INFO] Running org.apache.tomee.jul.handler.rotating.ArchivingTest
[ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 24.324 s <<< FAILURE! - in org.apache.tomee.jul.handler.rotating.ArchivingTest
[ERROR] logAndRotateAndPurge[gzip](org.apache.tomee.jul.handler.rotating.ArchivingTest) Time elapsed: 5.445 s <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.tomee.jul.handler.rotating.ArchivingTest.logAndRotateAndPurge(ArchivingTest.java:207)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143)
[INFO] Running org.apache.tomee.jul.handler.rotating.LocalFileHandlerPatternFormatterTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.064 s - in org.apache.tomee.jul.handler.rotating.LocalFileHandlerPatternFormatterTest
[INFO] Running org.apache.tomee.jul.handler.rotating.LocalFileHandlerTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.575 s - in org.apache.tomee.jul.handler.rotating.LocalFileHandlerTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ArchivingTest.logAndRotateAndPurge:207
[INFO]
[ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kakawait/tomee tomee-2155-upgrade-hsqldb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 7b1ad5f0aedcc2cad68b67604f0ec33acd3b511d
Author: Thibaud Leprêtre <th...@gmail.com>
Date: 2017-12-14T12:37:27Z
Upgrade HSQLDB to 2.3.5
HSQLDB 2.3.2 has regression that prevent:
> multiple rows with partial null values could not be inserted in UNIQUE indexes
See http://hsqldb.org/doc/2.0/changelist_2_0.txt 2.3.3 CHANGE_LOG
I would update to latest JRE 6 compatible HSQLDB version (except 2.4.0 that is required JRE 8)
Fixes TOMEE-2155
----
> Upgrade HSQLDB to >= 2.3.3 to fix 2.3.2 regression
> --------------------------------------------------
>
> Key: TOMEE-2155
> URL: https://issues.apache.org/jira/browse/TOMEE-2155
> Project: TomEE
> Issue Type: Dependency upgrade
> Affects Versions: 1.7.5, 7.0.2, 7.0.3, 7.0.4, 8.0.0, 7.0.5, 1.7.6, 7.0.6
> Reporter: Thibaud Lepretre
> Priority: Minor
> Labels: easyfix, pull-request-available
>
> As discussed on http://tomee-openejb.979440.n4.nabble.com/Upgrade-HSQLDB-to-fix-regression-on-2-3-2-td4683088.html
> TomEE 1.7, 7 or 8 bundles HSQLDB version 2.3.2, but this version has a major regression for our use case:
> http://hsqldb.org/doc/2.0/changelist_2_0.txt
> 28 June 2015 - version 2.3.3
> ...
> -- fixed regression in 2.3.2, multiple rows with partial null values could
> not be inserted in UNIQUE indexes
> ...
> I will create a PR on GitHub asap
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)