[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1778: WIP board: Keyboard FeatherWing on nrf52-feather

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #1778:
URL: https://github.com/apache/incubator-nuttx/pull/1778#discussion_r487948071



##########
File path: boards/arm/nrf52/nrf52-feather/Kconfig
##########
@@ -5,4 +5,54 @@
 
 if ARCH_BOARD_NRF52_FEATHER
 
-endif
+menuconfig NRF52_FEATHER_KB_FEATHERWING
+	bool "Keyboard FeatherWing"
+    default n
+    ---help---
+        Enable support for the SolderParty FeatherWing
+        https://www.solder.party/docs/keyboard-featherwing/
+
+if NRF52_FEATHER_KB_FEATHERWING
+config KB_FEATHERWING_LCD

Review comment:
       > 
   > 
   > @patacongo what are your thoughts here on how this calls select? Originally I had the LCD dependent on LCD_ILI9341 and no selects, but here it seems like you would want as a user to enable the top level hardware you have and have it turn on the required hardware.
   > 
   > I am fine changing this back if you think that makes sense. I just was thinking this would make is easy for a user.
   
   I agree with you.  FEATHERWING is like a "macro" that just automatically supports everything you need for the board.
   
   One question:  The use of the FeatherWing does not depend on NRF really.  It could be selected for any Feather board potentially.  So I wonder if this does not below in drivers/lcd and if it should not be named LCD_FEATHER_KB_FEATHERWING.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org