[GitHub] [incubator-superset] john-bodley opened a new pull request #7570: [testconn] Explicit closing engine connection

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #7570: [testconn] Explicit closing engine connection
URL: https://github.com/apache/incubator-superset/pull/7570
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   At Airbnb we noticed a number of SQLAlchemy QueuePool limit overflow issues similar to [this](https://stackoverflow.com/questions/24956894/sql-alchemy-queuepool-limit-overflow). 
   
   I've grokked the code an it seems everywhere we open a connection we explicitly close it (via `contextlib.closing`) except for the `/testconn` route. I'm not certain whether this is the cause of the issue, however we do call this route every 10 minutes and thus it seems like a viable candidate. 
   
   Note additionally the `/testconn` route used to return the list of tables associated with the database which seems like overkill when as `SELECT 1` would be suffice. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A
   
   ### TEST PLAN
   
   CI.
   
   ### REVIEWERS
   
   to: @graceguo-supercat @michellethomas @mistercrunch @soboko 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org