You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Cccccczj (via GitHub)" <gi...@apache.org> on 2024/10/11 09:12:09 UTC

[PR] add #define CPU_SETSIZE in sched.h [nuttx]

Cccccczj opened a new pull request, #14112:
URL: https://github.com/apache/nuttx/pull/14112

   add #define CPU_SETSIZE in sched.h to pass tlpi example: https://man7.org/tlpi/code/online/dist/procpri/t_sched_getaffinity.c.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] add #define CPU_SETSIZE in sched.h [nuttx]

Posted by "Cccccczj (via GitHub)" <gi...@apache.org>.
Cccccczj commented on PR #14112:
URL: https://github.com/apache/nuttx/pull/14112#issuecomment-2410546021

   fatal: unable to access 'https://github.com/espressif/esp32c3-bt-lib.git/': Failed to connect to github.com port 443 after 133320 ms: Connection timed out
   make[3]: *** [Makefile:53: v1.7.12.tar.gz] Error 28
   make[3]: *** [Makefile:112: 9356740cb0c264577e0f9505e682e53a1e0996d5.tar.gz] Error 28
   make[3]: Target 'context' not remade because of errors.
   make[3]: Target 'context' not remade because of errors.
   make[2]: *** [Makefile:54: /github/workspace/sources/apps/netutils/rtptools_context] Error 2
   make[2]: *** [Makefile:54: /github/workspace/sources/apps/netutils/cjson_context] Error 2
   make[2]: Target 'context_all' not remade because of errors.
   make[1]: *** [Makefile:181: context] Error 2
   fatal: clone of 'https://github.com/espressif/esp32c3-bt-lib.git' into submodule path '/github/workspace/sources/nuttx/arch/xtensa/src/esp32s3/esp-hal-3rdparty/components/bt/controller/lib_esp32c3_family' failed
   Failed to clone 'components/bt/controller/lib_esp32c3_family'. Retry scheduled
   make: *** [tools/Unix.mk:457: /github/workspace/sources/apps/.context] Error 2
   fatal: unable to access 'https://github.com/espressif/esp-coex-lib.git/': Failed to connect to github.com port 443 after 135153 ms: Connection timed out
   fatal: clone of 'https://github.com/espressif/esp-coex-lib.git' into submodule path '/github/workspace/sources/nuttx/arch/xtensa/src/esp32s3/esp-hal-3rdparty/components/esp_coex/lib' failed
   Failed to clone 'components/esp_coex/lib'. Retry scheduled
   make: Target 'all' not remade because of errors.
   /github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
     Normalize esp32s3-korvo-2/rtptools


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] add #define CPU_SETSIZE in sched.h [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14112:
URL: https://github.com/apache/nuttx/pull/14112#issuecomment-2406984623

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   ## PR Review against NuttX Requirements:
   
   **Meets Requirements?**  Partially
   
   **Summary:** 
   * The summary provides the "why" (needed for tlpi example), but lacks details on "what" and "how" the change is implemented. 
   
   **Impact:** 
   * The impact section is completely missing.  This is critical for reviewers to understand the breadth of the changes.
   
   **Testing:**
   * The PR description *must* include testing details:
       * What build hosts were used to validate? (OS, Compiler, etc.)
       * What target hardware or simulators were tested?
       * Provide *both* "before" and "after" logs demonstrating the fix.
   
   **Recommendations:**
   
   1. **Expand Summary:**  Clearly state WHAT `CPU_SETSIZE` is, HOW its definition helps the tlpi example, and WHERE in `sched.h` it's added.
   2. **Complete Impact Section:** Address ALL points, even if the answer is "NO" with a brief justification. Pay close attention to:
       * **Compatibility:** Does this macro definition affect other code?
       * **Documentation:**  Does `sched.h` need any comments for this?
   3. **Provide Thorough Testing Details:**  Follow the template's structure for logs.
   
   **Concisely:** The PR needs significant work to meet NuttX standards, particularly in impact assessment and testing evidence. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] add #define CPU_SETSIZE in sched.h [nuttx]

Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI merged PR #14112:
URL: https://github.com/apache/nuttx/pull/14112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org