[jira] [Commented] (ZOOKEEPER-1986) refactor log trace on touchSession

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072461#comment-14072461 ] 

Hadoop QA commented on ZOOKEEPER-1986:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12657440/ZOOKEEPER-1986.patch
  against trunk revision 1612906.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2222//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2222//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2222//console

This message is automatically generated.

> refactor log trace on touchSession
> ----------------------------------
>
>                 Key: ZOOKEEPER-1986
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1986
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Minor
>         Attachments: ZOOKEEPER-1986.patch
>
>
> The previous log trace has a minor mistake after applying ZOOKEEPER-1982:
> It will show "invalidsession" and "closingsession". There should be a whitespace in between.
> I might wanna further refactor the log wrapper function by using MessageFormat, which would be cleaner.



--
This message was sent by Atlassian JIRA
(v6.2#6252)