You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/11/05 12:36:41 UTC

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM

franz1981 commented on a change in pull request #2881: ARTEMIS-2538 Removing all messages from a huge queue causes OOM
URL: https://github.com/apache/activemq-artemis/pull/2881#discussion_r342539077
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ##########
 @@ -3880,9 +3889,12 @@ private DepageRunner(boolean scheduleExpiry) {
       @Override
       public void run() {
          try {
+            depageLock.lock();
 
 Review comment:
   move `depageLock.lock()` right before the `try` statement

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services