You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Andreas Schaefer <sc...@me.com.INVALID> on 2020/06/22 21:24:10 UTC
[VOTE] Release Apache Sling Kickstart and Kickstart Maven Plugin
version 0.0.4
Hi,
For most part this is a release to catch up with the changes / improvements of the Feature Model as a whole like support for Feature Archives and upgrading to newer releases.
NOTE: due to the dependencies of Kickstart Project to the Kickstart Maven Plugin and vice versa there could be some failures in the Jackson tests.
We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12348280
https://issues.apache.org/jira/projects/SLING/versions/12348424
There are still some outstanding issues:
https://issues.apache.org/jira/projects/SLING/versions/12348423
This was moved to the next release as this was not that important as the user
can use '-s' flag to accomplish the same thing.
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2288
You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage:
sh check_staged_release.sh 2288 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Cheers - Andy Schaefer
Re: [VOTE] Release Apache Sling Kickstart and Kickstart Maven Plugin
version 0.0.4
Posted by Daniel Klco <dk...@apache.org>.
+1
On Mon, Jun 22, 2020 at 5:24 PM Andreas Schaefer <sc...@me.com.invalid>
wrote:
> Hi,
>
> For most part this is a release to catch up with the changes /
> improvements of the Feature Model as a whole like support for Feature
> Archives and upgrading to newer releases.
>
> NOTE: due to the dependencies of Kickstart Project to the Kickstart Maven
> Plugin and vice versa there could be some failures in the Jackson tests.
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12348280
> https://issues.apache.org/jira/projects/SLING/versions/12348424
>
> There are still some outstanding issues:
> https://issues.apache.org/jira/projects/SLING/versions/12348423
>
> This was moved to the next release as this was not that important as the
> user
> can use '-s' flag to accomplish the same thing.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2288
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2288 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Cheers - Andy Schaefer
Re: [VOTE][CANCELLED] Release Apache Sling Kickstart and Kickstart
Maven Plugin version 0.0.4
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Jun 23, 2020 at 7:05 PM Andreas Schaefer
<sc...@me.com.invalid> wrote:
>
> ...Due to the issue with the big FAR file I do cancel this release, find a
> solution and then retry the vote on a later date....
Thank you very much, and sorry that this is delaying this release, but
I think it's important.
-Bertrand
Rewriting git repo history (was: [VOTE][CANCELLED] Release Apache
Sling Kickstart and Kickstart Maven Plugin version 0.0.4)
Posted by Robert Munteanu <ro...@apache.org>.
Hi Andy,
On Tue, 2020-06-23 at 10:04 -0700, Andreas Schaefer wrote:
> Do you want me to remove that file from the git repository with ‘git
> filter-branch’? I used that in the past and it works but I am not
> sure if it works with GitHub or if I am allowed to do it in the
> Apache repo.
I think it would be nice and probably carries little risk, as the
repository is still 'young'. People who have this checked out, and
probably Jenkins and SonarCloud may be affected.
Could you create an issue for this and push the results on a separate
repository outside of the apache org? We can then ask infra and
sonarcloud about side effects of this.
Thanks,
Robert
Re: [VOTE][CANCELLED] Release Apache Sling Kickstart and Kickstart
Maven Plugin version 0.0.4
Posted by Andreas Schaefer <sc...@me.com.INVALID>.
Due to the issue with the big FAR file I do cancel this release, find a solution and then retry the vote on a later date.
Regarding the big FAR file in the repository:
Do you want me to remove that file from the git repository with ‘git filter-branch’? I used that in the past and it works but I am not sure if it works with GitHub or if I am allowed to do it in the Apache repo.
Cheers - Andy
> On Jun 22, 2020, at 2:24 PM, Andreas Schaefer <sc...@me.com.INVALID> wrote:
>
> Hi,
>
> For most part this is a release to catch up with the changes / improvements of the Feature Model as a whole like support for Feature Archives and upgrading to newer releases.
>
> NOTE: due to the dependencies of Kickstart Project to the Kickstart Maven Plugin and vice versa there could be some failures in the Jackson tests.
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12348280
> https://issues.apache.org/jira/projects/SLING/versions/12348424
>
> There are still some outstanding issues:
> https://issues.apache.org/jira/projects/SLING/versions/12348423
>
> This was moved to the next release as this was not that important as the user
> can use '-s' flag to accomplish the same thing.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2288
>
> You can use this UNIX script to download the release and verify the signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2288 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Cheers - Andy Schaefer
Re: [VOTE] Release Apache Sling Kickstart and Kickstart Maven Plugin
version 0.0.4
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Jun 23, 2020 at 10:53 AM Robert Munteanu <ro...@apache.org> wrote:
> ...I asked earlier about checking in the FAR file to the git repository....
...
> Could this binary file be pulled in at runtime instead? ...
I think org.apache.sling.kickstart-0.0.4-source-release.zip cannot be
considered a "source release" as it contains a large aggregate of jar
files, so I'm -1 on this release.
I haven't followed previous discussions but there must be a better way
of distributing that org.apache.sling.kickstart.far
Compared to what we're doing for other things, I think that file
should be built from a pom that's in one of out Git repos and
distributed via Maven Central as an attached artifact, using [1] or
something similar. Creating a specific Git repository for that is fine
if that's convenient.
-Bertrand
[1] https://www.mojohaus.org/build-helper-maven-plugin/attach-artifact-mojo.html
Re: [VOTE] Release Apache Sling Kickstart and Kickstart Maven
Plugin version 0.0.4
Posted by Robert Munteanu <ro...@apache.org>.
Hi Andy and thanks for stepping up with a new release.
I asked earlier about checking in the FAR file to the git repository. I
guess it was missed due to the non-descript subject line, sorry about
that
https://lists.apache.org/thread.html/r253ae564eadb877fce0af52b6f5f7a04b0b527dbd7bb82c4324b9c8e%40%3Cdev.sling.apache.org%3E
As a general note, I think we should be wary of checking in binaries to
git. With a 80 MB binary file cloning is slower, and that affects
developers, CI servers, and potentially others. Moreover, with the
nature of Git, these blobs will stay in the repository forever, and
refreshing the FAR file 10 times will yield a 800MB payload, which is
really large.
Also, the release artifacts contain it as well, including the source
release, which IMO does not make that much sense, and it's putting
pressure on our mirrors.
https://repository.apache.org/content/repositories/orgapachesling-2288/org/apache/sling/org.apache.sling.kickstart/0.0.4/
I am not sure ATM if it is actually a problem in a legal sense to
include a jar file in a source release. However, I think it is not
fully in the spirit of a source release.
Could this binary file be pulled in at runtime instead?
Thanks,
Robert
On Mon, 2020-06-22 at 14:24 -0700, Andreas Schaefer wrote:
> Hi,
>
> For most part this is a release to catch up with the changes /
> improvements of the Feature Model as a whole like support for Feature
> Archives and upgrading to newer releases.
>
> NOTE: due to the dependencies of Kickstart Project to the Kickstart
> Maven Plugin and vice versa there could be some failures in the
> Jackson tests.
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12348280
> https://issues.apache.org/jira/projects/SLING/versions/12348424
>
> There are still some outstanding issues:
> https://issues.apache.org/jira/projects/SLING/versions/12348423
>
> This was moved to the next release as this was not that important as
> the user
> can use '-s' flag to accomplish the same thing.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2288
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2288 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Cheers - Andy Schaefer