You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/10 12:33:06 UTC

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4294: Fixing some issues docs/getting_started.rst

sunithabeeram commented on a change in pull request #4294: Fixing some issues docs/getting_started.rst
URL: https://github.com/apache/incubator-pinot/pull/4294#discussion_r291991192
 
 

 ##########
 File path: docs/getting_started.rst
 ##########
 @@ -154,7 +155,7 @@ To upload the schema, we can use the command below:
 
 .. code-block:: none
 
-  $ ./pinot-distribution/target/apache-pinot-incubating-0.1.0-SNAPSHOT-bin/apache-pinot-incubating-0.1.0-SNAPSHOT-bin/bin/pinot-admin.sh AddSchema -schemaFile /Users/host1/transcript-schema.json -exec
+  $ ./pinot-distribution/target/apache-pinot-incubating-$PINOT_VERSION-SNAPSHOT-bin/apache-pinot-incubating-$PINOT_VERSION-SNAPSHOT-bin/bin/pinot-admin.sh AddSchema -schemaFile /Users/host1/transcript-schema.json -exec
 
 Review comment:
   SNAPSHOT should be part of the version string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org