[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17#discussion_r57946105
  
    --- Diff: extras/java8-tests/README.md ---
    @@ -0,0 +1,24 @@
    +# Java 8 Test Suites
    +
    +These tests require having Java 8 installed and are isolated from the main Spark build.
    +If Java 8 is not your system's default Java version, you will need to point Spark's build
    +to your Java location. The set-up depends a bit on the build system:
    +
    +* Sbt users can either set JAVA_HOME to the location of a Java 8 JDK or explicitly pass
    +  `-java-home` to the sbt launch script. If a Java 8 JDK is detected sbt will automatically
    +  include the Java 8 test project.
    +
    +  `$ JAVA_HOME=/opt/jdk1.8.0/ sbt/sbt clean "test-only org.apache.spark.Java8APISuite"`
    +
    +* For Maven users,
    +
    +  Maven users can also refer to their Java 8 directory using JAVA_HOME. However, Maven will not
    +  automatically detect the presence of a Java 8 JDK, so a special build profile `-Pjava8-tests`
    --- End diff --
    
    It looks like this actually _can_ be done because Maven profiles can be activated automatically based on the JDK; see the JDK examples at https://maven.apache.org/guides/introduction/introduction-to-profiles.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org