You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/06 01:34:04 UTC
Review Request 43276: Fix compilation on Ubuntu 15.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43276/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Michael Park, and Neil Conway.
Bugs: MESOS-4479
https://issues.apache.org/jira/browse/MESOS-4479
Repository: mesos
Description
-------
A few signed-unsigned comparisons introduced by https://reviews.apache.org/r/42751/
Diffs
-----
src/tests/resources_tests.cpp 3a338835757001d2987f80016a9029085cd7ff3b
Diff: https://reviews.apache.org/r/43276/diff/
Testing
-------
make check (Ubuntu15)
Thanks,
Joseph Wu
Re: Review Request 43276: Fix compilation on Ubuntu 15.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43276/#review118117
-----------------------------------------------------------
Ship it!
LGTM! Compiles and tests successfully under both gcc-5.3.0 (homebrew) and clang (today's trunk).
- Benjamin Bannier
On Feb. 6, 2016, 1:34 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43276/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2016, 1:34 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A few signed-unsigned comparisons introduced by https://reviews.apache.org/r/42751/
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 3a338835757001d2987f80016a9029085cd7ff3b
>
> Diff: https://reviews.apache.org/r/43276/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu15)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43276: Fix compilation on Ubuntu 15.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43276/#review118124
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 6, 2016, 12:34 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43276/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2016, 12:34 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A few signed-unsigned comparisons introduced by https://reviews.apache.org/r/42751/
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 3a338835757001d2987f80016a9029085cd7ff3b
>
> Diff: https://reviews.apache.org/r/43276/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu15)
>
>
> Thanks,
>
> Joseph Wu
>
>