You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/09/15 15:18:00 UTC
[jira] [Comment Edited] (CASSANDRA-16882) Save CircleCI resources
with optional test jobs
[ https://issues.apache.org/jira/browse/CASSANDRA-16882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415586#comment-17415586 ]
Ekaterina Dimitrova edited comment on CASSANDRA-16882 at 9/15/21, 3:17 PM:
---------------------------------------------------------------------------
Consensus reached in [Slack |https://the-asf.slack.com/archives/CK23JSY2K/p1631627458109000], publishing a summary here:
* Instead of having a minimum required tests, the community agreed we can have a pre-commit job which covers all jobs except the python upgrade tests. of course, those shouldn't be skipped by anyone when they make sense (not for fixing unrelated test bug for example as they are taking all resources).
* We can request a required field from Infra for Test build link similar to the Source Control Link one we currently have.
Please feel free to add anything I might have missed. Thank you to everyone who spend the time for a fruitful discussion.
was (Author: e.dimitrova):
Consensus reached in [Slack |https://the-asf.slack.com/archives/CK23JSY2K/p1631627458109000|https://urldefense.proofpoint.com/v2/url?u=https-3A__the-2Dasf.slack.com_archives_CK23JSY2K_p1631627458109000&d=DwMBaQ&c=adz96Xi0w1RHqtPMowiL2g&r=4OZU_3AS7gzaAWcWmh7XcRWUDDtEKP19i124LAT3eqA&m=T3FK_onArHR7_m3-P5eSQ9MmpqYVqp4sN_w8UjU2PJA&s=DapuifvZx4abu3CJmhG3Sk1saI602WGAWzr0119-CqU&e=], publishing a summary here:
* Instead of having a minimum required tests, the community agreed we can have a pre-commit job which covers all jobs except the python upgrade tests. Those shouldn't be skipped by anyone when they make sense (not for fixing unrelated test bug for example as they are taking all resources).
* We can request a required field from Infra for Test build link similar to the Source Control Link one we currently have.
Please feel free to add anything I might have missed. Thank you to everyone who spend the time for a fruitful discussion.
> Save CircleCI resources with optional test jobs
> -----------------------------------------------
>
> Key: CASSANDRA-16882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16882
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
>
> This ticket implements the addition of approval steps in the CircleCI workflows as it was proposed in [this email|https://lists.apache.org/thread.html/r57bab800d037c087af01b3779fd266d83b538cdd29c120f74a5dbe63%40%3Cdev.cassandra.apache.org%3E] sent to the dev list:
> The current CircleCI configuration automatically runs the unit tests, JVM dtests and cqhshlib tests. This is done by default for every commit or, with some configuration, for every push.
> Along the lifecycle of a ticket it is quite frequent to have multiple commits and pushes, all running these test jobs. I'd say that frequently it is not necessary to run the tests for some of those intermediate commits and pushes. For example, one can show proofs of concept, or have multiple rounds of review before actually running the tests. Running the tests for every change can produce an unnecessary expense of CircleCI resources.
> I think we could make running those tests optional, as well as clearly specifying in the documentation what are the tests runs that are mandatory before actually committing. We could do this in different ways:
> # Make the entire CircleCI workflow optional, so the build job requires
> manual approval. Once the build is approved the mandatory test jobs would
> be run without any further approval, exactly as it's currently done.
> # Make all the test jobs optional, so every test job requires manual approval, and the documentation specifies which tests are mandatory in the final steps of a ticket.
> # Make all the mandatory test jobs depend on a single optional job, so we have a single button to optionally run all the mandatory tests.
> I think any of these changes, or a combination of them, would significantly
> reduce the usage of resources without making things less tested. The only
> downside I can think of is that we would need some additional clicks on the
> CircleCI GUI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org