You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/09 09:32:48 UTC
[GitHub] [ozone] cchenax opened a new pull request #2397: HDDS-5402 Support list node based on NodeOperationalState and NodeState options in printTopology CLI
cchenax opened a new pull request #2397:
URL: https://github.com/apache/ozone/pull/2397
## What changes were proposed in this pull request?
Currently, printTopology CLI display all DN information as output.
This task is to add NodeOperationalState and NodeState as the CLI options to the command, and display the DN accordingly.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5402
## How was this patch tested?
bin/ozone admin datanode list --NodeOperationalState IN_SERVICE
bin/ozone admin datanode list --NodeState HEALTHY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2397: HDDS-5402 Support list node based on NodeOperationalState and NodeState options in printTopology CLI
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2397:
URL: https://github.com/apache/ozone/pull/2397#discussion_r667596128
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java
##########
@@ -51,6 +51,16 @@
defaultValue = "")
private String uuid;
+ @CommandLine.Option(names = {"--NodeOperationalState"},
+ description = "Show info by datanode NodeOperationalState.",
Review comment:
Please add all available NodeOperationalState values in the description to asssit user's better choice.
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java
##########
@@ -51,6 +51,16 @@
defaultValue = "")
private String uuid;
+ @CommandLine.Option(names = {"--NodeOperationalState"},
+ description = "Show info by datanode NodeOperationalState.",
+ defaultValue = "")
+ private String nodeOperationalState;
+
+ @CommandLine.Option(names = {"--NodeState"},
+ description = "Show info by datanode NodeState.",
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2397: HDDS-5403 Support list node based on NodeOperationalState and NodeState options in datanode list CLI
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2397:
URL: https://github.com/apache/ozone/pull/2397#discussion_r668468319
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java
##########
@@ -51,6 +51,19 @@
defaultValue = "")
private String uuid;
+ @CommandLine.Option(names = {"--NodeOperationalState"},
+ description = "Show info by datanode NodeOperationalState." +
+ "IN_SERVICE DECOMMISSIONING DECOMMISSIONED ENTERING_MAINTENANCE" +
Review comment:
Please change the description to the following format "Show info by datanode NodeOperationalState(IN_SERVICE, DECOMMISSIONING, DECOMMISSIONED, ENTERING_MAINTENANCE, IN_MAINTENANCE)."
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java
##########
@@ -51,6 +51,19 @@
defaultValue = "")
private String uuid;
+ @CommandLine.Option(names = {"--NodeOperationalState"},
+ description = "Show info by datanode NodeOperationalState." +
+ "IN_SERVICE DECOMMISSIONING DECOMMISSIONED ENTERING_MAINTENANCE" +
+ "IN_MAINTENANCE",
+ defaultValue = "")
+ private String nodeOperationalState;
+
+ @CommandLine.Option(names = {"--NodeState"},
+ description = "Show info by datanode NodeState." +
+ " HEALTHY STALE DEAD",
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2397: HDDS-5403 Support list node based on NodeOperationalState and NodeState options in datanode list CLI
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2397:
URL: https://github.com/apache/ozone/pull/2397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2397: HDDS-5403 Support list node based on NodeOperationalState and NodeState options in datanode list CLI
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2397:
URL: https://github.com/apache/ozone/pull/2397#discussion_r668470533
##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/datanode.robot
##########
@@ -34,6 +34,14 @@ Filter list by UUID
${count} = Get Length ${lines}
Should Be Equal As Integers ${count} 1
+Filter list by NodeOperationalState
+ ${output} = Execute ozone admin datanode list --NodeOperationalState IN_SERVICE
+ Should contain ${output} Datanode:
Review comment:
Can you add a datanode UUID to the "Datanode:" string ?
##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/datanode.robot
##########
@@ -34,6 +34,14 @@ Filter list by UUID
${count} = Get Length ${lines}
Should Be Equal As Integers ${count} 1
+Filter list by NodeOperationalState
+ ${output} = Execute ozone admin datanode list --NodeOperationalState IN_SERVICE
+ Should contain ${output} Datanode:
+
+Filter list by NodeState
+ ${output} = Execute ozone admin datanode list --NodeState HEALTHY
+ Should contain ${output} Datanode:
Review comment:
Same as above
##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/datanode.robot
##########
@@ -34,6 +34,14 @@ Filter list by UUID
${count} = Get Length ${lines}
Should Be Equal As Integers ${count} 1
+Filter list by NodeOperationalState
+ ${output} = Execute ozone admin datanode list --NodeOperationalState IN_SERVICE
+ Should contain ${output} Datanode:
+
+Filter list by NodeState
+ ${output} = Execute ozone admin datanode list --NodeState HEALTHY
+ Should contain ${output} Datanode:
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2397: HDDS-5403 Support list node based on NodeOperationalState and NodeState options in datanode list CLI
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2397:
URL: https://github.com/apache/ozone/pull/2397#issuecomment-881125029
The last patch LGTM，+1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] cchenax commented on a change in pull request #2397: HDDS-5403 Support list node based on NodeOperationalState and NodeState options in datanode list CLI
Posted by GitBox <gi...@apache.org>.
cchenax commented on a change in pull request #2397:
URL: https://github.com/apache/ozone/pull/2397#discussion_r668470383
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java
##########
@@ -51,6 +51,19 @@
defaultValue = "")
private String uuid;
+ @CommandLine.Option(names = {"--NodeOperationalState"},
+ description = "Show info by datanode NodeOperationalState." +
+ "IN_SERVICE DECOMMISSIONING DECOMMISSIONED ENTERING_MAINTENANCE" +
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org