You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@pivot.apache.org by Dirk Möbius <dm...@scoop-gmbh.de> on 2010/12/03 18:00:02 UTC
Errors in TableRowEditor demo
I tested the recent changes to TableViewRowEditor (rev. 1041399 as of
12/02/10). Two issues:
1) When using a german locale (my system default), the edit field for
Amount goes red immediately, because the displayed value "30,00"
doesn't match the validation format mask. Oddly, "30,00" is a correct
german currency value, because in Germany "," is the decimal
separator, not ".". So I suspect that the field editor uses a
hardwired format mask "##'.'##", which works in english countries
only. When I change the value to be "30.00" the field validates
successful and I can close the row editor. But "30.00" is not a valid
german decimal value; "30,00" is.
2) When the row editor is open, I cannot click anything in the row.
Mouse events seem to be blocked or consumed. I cannot click on the
Type drop-down nor change the Date with the Up/Down arrow buttons.
Tabbing through the fields with the keyboard works, though.
This also happens with the recently uploaded Pivot 2.0 demos at
http://ixnay.biz/pivot-demos/table-row-editor.html
Regards,
Dirk.
Re: Errors in TableRowEditor demo
Posted by Dirk Möbius <dm...@scoop-gmbh.de>.
Done. PIVOT-681.
Dirk.
Greg Brown <gk...@verizon.net> wrote:
> Cool - can you submit it via a JIRA ticket? Thanks.
> G
>
> On Dec 3, 2010, at 1:06 PM, Dirk Möbius wrote:
>
>> Ok, here it it.
>>
>> The CurrencyValidator is a little bit complicated, because if I'd
>> use a plain NumberFormat, it would accept number input with
>> trailing text, e.g. "30.30foo". Therefore I used
>> parse(String,ParsePosition) which checks the parse position for
>> trailing text explicitly.
>>
>>
>>
>> I wrote:
>>> Greg Brown <gk...@verizon.net> wrote:
>>>> Yeah, this is a known issue. That demo isn't fully localized. You
>>>> are more than welcome to update it to support localized currency
>>>> formats if you like.
>>>
>>> I'll have a look at it.
>>>
>>>> Whoops. Fixed - thanks.
>>>
>>> Whoa, fast! Thanks! :)
>>>
>>> Dirk.
Re: Errors in TableRowEditor demo
Posted by Greg Brown <gk...@verizon.net>.
Cool - can you submit it via a JIRA ticket? Thanks.
G
On Dec 3, 2010, at 1:06 PM, Dirk Möbius wrote:
> Ok, here it it.
>
> The CurrencyValidator is a little bit complicated, because if I'd use a plain NumberFormat, it would accept number input with trailing text, e.g. "30.30foo". Therefore I used parse(String,ParsePosition) which checks the parse position for trailing text explicitly.
>
>
>
> I wrote:
>> Greg Brown <gk...@verizon.net> wrote:
>>> Yeah, this is a known issue. That demo isn't fully localized. You are more than welcome to update it to support localized currency formats if you like.
>>
>> I'll have a look at it.
>>
>>> Whoops. Fixed - thanks.
>>
>> Whoa, fast! Thanks! :)
>>
>> Dirk.
>>
>>
>>
>
>
>
> --
> Dirk Möbius
>
> SCOOP GmbH
> Am Kielshof 29
> D-51105 Köln
> Fon +49 221 801916-0
> Fax +49 221 801916-17
> Mobil +49 170 7363035
> www.scoop-gmbh.de
> Sitz der Gesellschaft: Köln
> Handelsregister: Köln
> Handelsregisternummer: HRB 36623
> Geschäftsführer:
> Dr. Oleg Balovnev
> Frank Heinen
> Dr. Wolfgang Reddig
> Roland Scheel
> <tableroweditor-demo.patch>
Re: Errors in TableRowEditor demo
Posted by Dirk Möbius <dm...@scoop-gmbh.de>.
Ok, here it it.
The CurrencyValidator is a little bit complicated, because if I'd use
a plain NumberFormat, it would accept number input with trailing text,
e.g. "30.30foo". Therefore I used parse(String,ParsePosition) which
checks the parse position for trailing text explicitly.
I wrote:
> Greg Brown <gk...@verizon.net> wrote:
>> Yeah, this is a known issue. That demo isn't fully localized. You
>> are more than welcome to update it to support localized currency
>> formats if you like.
>
> I'll have a look at it.
>
>> Whoops. Fixed - thanks.
>
> Whoa, fast! Thanks! :)
>
> Dirk.
>
>
>
--
Dirk Möbius
SCOOP GmbH
Am Kielshof 29
D-51105 Köln
Fon +49 221 801916-0
Fax +49 221 801916-17
Mobil +49 170 7363035
www.scoop-gmbh.de
Sitz der Gesellschaft: Köln
Handelsregister: Köln
Handelsregisternummer: HRB 36623
Geschäftsführer:
Dr. Oleg Balovnev
Frank Heinen
Dr. Wolfgang Reddig
Roland Scheel
Re: Errors in TableRowEditor demo
Posted by Dirk Möbius <dm...@scoop-gmbh.de>.
Greg Brown <gk...@verizon.net> wrote:
> Yeah, this is a known issue. That demo isn't fully localized. You
> are more than welcome to update it to support localized currency
> formats if you like.
I'll have a look at it.
> Whoops. Fixed - thanks.
Whoa, fast! Thanks! :)
Dirk.
Re: Errors in TableRowEditor demo
Posted by Greg Brown <gk...@verizon.net>.
> 1) When using a german locale (my system default), the edit field for Amount goes red immediately, because the displayed value "30,00" doesn't match the validation format mask. Oddly, "30,00" is a correct german currency value, because in Germany "," is the decimal separator, not ".". So I suspect that the field editor uses a hardwired format mask "##'.'##", which works in english countries only. When I change the value to be "30.00" the field validates successful and I can close the row editor. But "30.00" is not a valid german decimal value; "30,00" is.
Yeah, this is a known issue. That demo isn't fully localized. You are more than welcome to update it to support localized currency formats if you like.
> 2) When the row editor is open, I cannot click anything in the row. Mouse events seem to be blocked or consumed. I cannot click on the Type drop-down nor change the Date with the Up/Down arrow buttons.
> Tabbing through the fields with the keyboard works, though.
>
> This also happens with the recently uploaded Pivot 2.0 demos at http://ixnay.biz/pivot-demos/table-row-editor.html
Whoops. Fixed - thanks.