You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/31 13:02:53 UTC

[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request #2261: [KYUUBI #2257] The running query will not update the duration of the page

cxzl25 opened a new pull request #2261:
URL: https://github.com/apache/incubator-kyuubi/pull/2261


   ### _Why are the changes needed?_
   close https://github.com/apache/incubator-kyuubi/issues/2260
   
   The default value of completedTime is 0, and the calculation of duration only considers the case where completedTime is -1.
   
   org.apache.kyuubi.operation.AbstractOperation
   ```scala
   protected var completedTime: Long = _
   ````
   
   org.apache.kyuubi.engine.spark.events.SparkOperationEvent
   ```scala
     def duration: Long = {
       if (completeTime == -1L) {
         System.currentTimeMillis - createTime
       } else {
         completeTime - createTime
       }
     }
   ```
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #2261: [KYUUBI #2260] The running query will not update the duration of the page

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #2261:
URL: https://github.com/apache/incubator-kyuubi/pull/2261


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2261: [KYUUBI #2260] The running query will not update the duration of the page

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #2261:
URL: https://github.com/apache/incubator-kyuubi/pull/2261#issuecomment-1085307122


   @cfmcgrady you can do the first shot : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2261: [KYUUBI #2260] The running query will not update the duration of the page

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #2261:
URL: https://github.com/apache/incubator-kyuubi/pull/2261#issuecomment-1086604792


   thanks, merging to master 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2261: [KYUUBI #2260] The running query will not update the duration of the page

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2261:
URL: https://github.com/apache/incubator-kyuubi/pull/2261#issuecomment-1084553581


   ## Current
   ![image](https://user-images.githubusercontent.com/3898450/161061187-aea00b6d-a2c8-4bdc-b900-de3d3879fddb.png)
   ## Fix
   ![image](https://user-images.githubusercontent.com/3898450/161061700-ce455043-8fed-4729-a2f9-dc1e41df972d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org