[jira] Commented: (PROTOCOLS-11) Make CommandHandler/LineHandler/ConnectHandler more consistent

["Stefano Bagnara (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTOCOLS-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933341#action_12933341 ] 

Stefano Bagnara commented on PROTOCOLS-11:
------------------------------------------

We made this way to make it simpler to write CommandHandler. The simplicity could not be ported to Connect/LIne handler because they are more powerful, but the CommandHandler pattern is simpler to implement correctly: implementors are "forced" by the interface to do the right thing. In SMTP/POP3 there are no commands that do not return, and they always returns one result in response to one command.

> Make CommandHandler/LineHandler/ConnectHandler more consistent
> --------------------------------------------------------------
>
>                 Key: PROTOCOLS-11
>                 URL: https://issues.apache.org/jira/browse/PROTOCOLS-11
>             Project: JAMES Protocols
>          Issue Type: Task
>    Affects Versions: 1.0, 1.1
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 1.2-M2
>
>
> At the moment we have three different Handler types. These are ConnectHandler, CommandHandler and LineHandler. The ConnectHandler and LineHandler use void as return type and so if you want to write something back to the client you use Session.write(...). On the other hand if you use CommandHandler you can use the return type of Response to trigger a write back to the client and Session.write(..).  We should only use Session.write(...) in all cases

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org