You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/05/21 16:01:48 UTC

[GitHub] [solr] HoustonPutman opened a new pull request #141: SOLR-15241: Add Docker & Kubernetes info to the README

HoustonPutman opened a new pull request #141:
URL: https://github.com/apache/solr/pull/141


   https://issues.apache.org/jira/browse/SOLR-15241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] madrob commented on a change in pull request #141: SOLR-15241: Add Docker & Kubernetes info to the README

Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #141:
URL: https://github.com/apache/solr/pull/141#discussion_r637240118



##########
File path: README.md
##########
@@ -90,6 +90,36 @@ Common options are described in some detail in solr/README.txt.  For an
 exhaustive treatment of options, run `bin/solr start -h` from the `solr/`
 directory.
 
+### Running Solr in Docker
+
+You can run Solr in Docker via the [official image](https://hub.docker.com/_/solr).
+
+To simply run Solr in a container and expose the Solr port, run:

Review comment:
       s/simply//
   
   I learned this trick from a tech writer friend a while ago, that you never want to say simply, or just, or obviously, in the documentation. Because while it may be simple to you as the writer, it's probably not simple to the reader and that's why they are reading the docs in the first place. We don't need to insult our readers. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] anshumg commented on a change in pull request #141: SOLR-15241: Add Docker & Kubernetes info to the README

Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #141:
URL: https://github.com/apache/solr/pull/141#discussion_r638073423



##########
File path: README.md
##########
@@ -90,6 +90,36 @@ Common options are described in some detail in solr/README.txt.  For an
 exhaustive treatment of options, run `bin/solr start -h` from the `solr/`
 directory.
 
+### Running Solr in Docker
+
+You can run Solr in Docker via the [official image](https://hub.docker.com/_/solr).
+
+To run Solr in a container and expose the Solr port, run:
+
+`docker run -p 8983:8983 solr`
+
+In order to start Solr in cloud mode, run the following.
+
+`docker run -p 8983:8983 solr solr-fg -c`
+
+For documentation on using the official docker builds, please refer to the [DockerHub page](https://hub.docker.com/_/solr).
+Documentation up to date with this branch, useful for running locally-built images, can be found in the [reference guide](solr/solr-ref-guide/src/running-solr-in-docker.adoc).

Review comment:
       how about rephrasing this to 
   ```Up to date documentation for running locally built images of this branch can be found ....```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman merged pull request #141: SOLR-15241: Add Docker & Kubernetes info to the README

Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #141:
URL: https://github.com/apache/solr/pull/141


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org