You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/21 03:34:00 UTC
[GitHub] [flink] lirui-apache commented on a change in pull request #9457:
[FLINK-13741][table] "SHOW FUNCTIONS" should include Flink built-in
functions' names
lirui-apache commented on a change in pull request #9457: [FLINK-13741][table] "SHOW FUNCTIONS" should include Flink built-in functions' names
URL: https://github.com/apache/flink/pull/9457#discussion_r315982380
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
##########
@@ -222,7 +222,7 @@ public void testListUserDefinedFunctions() throws Exception {
final List<String> actualTables = executor.listUserDefinedFunctions(session);
- final List<String> expectedTables = Arrays.asList("aggregateUDF", "tableUDF", "scalarUDF");
+ final List<String> expectedTables = Arrays.asList("aggregateUDF", "scalarUDF", "tableUDF");
Review comment:
I think either we should mention in the JavaDoc that the returned list is sorted, or the test should verify with a set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services