[GitHub] [incubator-uniffle] frankliee commented on a diff in pull request #213: Fast fail when reading failed in ComposedClientReadHandler

[GitBox <gi...@apache.org>]

frankliee commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r971501022


##########
integration-test/common/src/test/java/org/apache/uniffle/test/QuorumTest.java:
##########
@@ -573,7 +574,12 @@ public void case7() throws Exception {
         testAppId, 0, 0, 100, 1,
         10, 1000, "", blockIdBitmap, taskIdBitmap,
         Lists.newArrayList(shuffleServerInfo2), null, new DefaultIdHelper());
-    assertTrue(readClient.readShuffleBlockData() == null);
+    try {
+      readClient.readShuffleBlockData();
+      fail();
+    } catch (RssException e) {
+      // ignore

Review Comment:
   Could you add some log to help diagnose  when tests are broken. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org