You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/14 03:58:59 UTC
[PR] fix: validate requests at service boundaries [rocketmq-dashboard]
tju-yxq opened a new pull request, #2163:
URL: https://github.com/apache/rocketmq-dashboard/pull/2163
Fixes #1798, #1802, #1818, #1820, and #1826.
This consolidates the five service-boundary validation fixes from the closed PRs #1799, #1811, #1819, #1821, and #1827, following the maintainer guidance in #2107.
The changes keep invalid input from reaching repositories, endpoint resolution, queue scanning, or audit writes:
- normalize and validate plain ACL `whiteRemoteAddress` before persistence;
- require and normalize the DLQ consumer group, and reject `begin >= end` before endpoint resolution;
- require and trim alert rule names before create/update persistence and auditing;
- convert unsupported K8s certificate types to 400 `BusinessException`s, with invalid update types rejected before repository lookup;
- cover both service behavior and the relevant HTTP error mapping.
## Testing
```bash
cd server
mvn -DskipTests=false "-Dtest=AclServiceTest,AclControllerTest,RocketMQDLQProviderTest,AlertServiceTest,K8sCertServiceTest,K8sCertControllerTest" test
mvn -DskipTests=false test
```
Results:
- focused suite: `BUILD SUCCESS` — 169 tests, 0 failures, 0 errors;
- full server suite: `BUILD SUCCESS` — 1,204 tests, 0 failures, 0 errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: validate requests at service boundaries [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #2163:
URL: https://github.com/apache/rocketmq-dashboard/pull/2163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org