You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ruth Cao (JIRA)" <ji...@apache.org> on 2007/03/19 10:38:32 UTC
[jira] Created: (HARMONY-3422) [classlib][testing]move
tests.api.java.net.URLTest out of the exclude list
[classlib][testing]move tests.api.java.net.URLTest out of the exclude list
--------------------------------------------------------------------------
Key: HARMONY-3422
URL: https://issues.apache.org/jira/browse/HARMONY-3422
Project: Harmony
Issue Type: Test
Components: Classlib
Reporter: Ruth Cao
Current t.a.j.n.URLTest has several problems:
1. test_URLStreamHandler_parseURL fails since URLStreamHandlerFactory has been already set in the method test_setURLStreamHandlerFactoryLjava_net_URLStreamHandlerFactory()
2. Lack of resource jar files and an embedded HTTP server in test_openStream.
3. Lack of an embedded proxy server in test_openConnectionLjava_net_Proxy()
For the first two issues, I'll try to fix it. For the last one, move it into t.a.j.n.ExcludedProxyTest temporarily and enable it when Jetty's Proxy Handler is ready.
Any comments and suggestions are welcome, thanks a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3422) [classlib][testing]move
tests.api.java.net.URLTest out of the exclude list
Posted by "Ruth Cao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruth Cao updated HARMONY-3422:
------------------------------
Attachment: Harmony-3422.diff
I've created a new patch, the following is my solution about the problem mentioned above:
1. For the setURLStreamHandlerFactory method, since we cannot reset the factory, IMO the related test cases should be removed so that it won't affect the tests that are run after it.
2. Find the existing jar file resources within support module and start an embedded HTTP server using Jetty
Any ideas? And may somebody pls try this one?
> [classlib][testing]move tests.api.java.net.URLTest out of the exclude list
> --------------------------------------------------------------------------
>
> Key: HARMONY-3422
> URL: https://issues.apache.org/jira/browse/HARMONY-3422
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Ruth Cao
> Attachments: Harmony-3422.diff
>
>
> Current t.a.j.n.URLTest has several problems:
> 1. test_URLStreamHandler_parseURL fails since URLStreamHandlerFactory has been already set in the method test_setURLStreamHandlerFactoryLjava_net_URLStreamHandlerFactory()
> 2. Lack of resource jar files and an embedded HTTP server in test_openStream.
> 3. Lack of an embedded proxy server in test_openConnectionLjava_net_Proxy()
> For the first two issues, I'll try to fix it. For the last one, move it into t.a.j.n.ExcludedProxyTest temporarily and enable it when Jetty's Proxy Handler is ready.
> Any comments and suggestions are welcome, thanks a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3422) [classlib][testing]move
tests.api.java.net.URLTest out of the exclude list
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paulex Yang reassigned HARMONY-3422:
------------------------------------
Assignee: Paulex Yang
> [classlib][testing]move tests.api.java.net.URLTest out of the exclude list
> --------------------------------------------------------------------------
>
> Key: HARMONY-3422
> URL: https://issues.apache.org/jira/browse/HARMONY-3422
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Ruth Cao
> Assigned To: Paulex Yang
> Attachments: Harmony-3422.diff
>
>
> Current t.a.j.n.URLTest has several problems:
> 1. test_URLStreamHandler_parseURL fails since URLStreamHandlerFactory has been already set in the method test_setURLStreamHandlerFactoryLjava_net_URLStreamHandlerFactory()
> 2. Lack of resource jar files and an embedded HTTP server in test_openStream.
> 3. Lack of an embedded proxy server in test_openConnectionLjava_net_Proxy()
> For the first two issues, I'll try to fix it. For the last one, move it into t.a.j.n.ExcludedProxyTest temporarily and enable it when Jetty's Proxy Handler is ready.
> Any comments and suggestions are welcome, thanks a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3422) [classlib][testing]move
tests.api.java.net.URLTest out of the exclude list
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess closed HARMONY-3422.
---------------------------------
Closing as the fix has been verified and the test has been removed from the exclude lists.
> [classlib][testing]move tests.api.java.net.URLTest out of the exclude list
> --------------------------------------------------------------------------
>
> Key: HARMONY-3422
> URL: https://issues.apache.org/jira/browse/HARMONY-3422
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Ruth Cao
> Assignee: Paulex Yang
> Attachments: Harmony-3422.diff
>
>
> Current t.a.j.n.URLTest has several problems:
> 1. test_URLStreamHandler_parseURL fails since URLStreamHandlerFactory has been already set in the method test_setURLStreamHandlerFactoryLjava_net_URLStreamHandlerFactory()
> 2. Lack of resource jar files and an embedded HTTP server in test_openStream.
> 3. Lack of an embedded proxy server in test_openConnectionLjava_net_Proxy()
> For the first two issues, I'll try to fix it. For the last one, move it into t.a.j.n.ExcludedProxyTest temporarily and enable it when Jetty's Proxy Handler is ready.
> Any comments and suggestions are welcome, thanks a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3422) [classlib][testing]move
tests.api.java.net.URLTest out of the exclude list
Posted by "Ruth Cao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487498 ]
Ruth Cao commented on HARMONY-3422:
-----------------------------------
Yes, Paulex. The fix looks great and the entry of the test should be removed. Thanks.
> [classlib][testing]move tests.api.java.net.URLTest out of the exclude list
> --------------------------------------------------------------------------
>
> Key: HARMONY-3422
> URL: https://issues.apache.org/jira/browse/HARMONY-3422
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Ruth Cao
> Assigned To: Paulex Yang
> Attachments: Harmony-3422.diff
>
>
> Current t.a.j.n.URLTest has several problems:
> 1. test_URLStreamHandler_parseURL fails since URLStreamHandlerFactory has been already set in the method test_setURLStreamHandlerFactoryLjava_net_URLStreamHandlerFactory()
> 2. Lack of resource jar files and an embedded HTTP server in test_openStream.
> 3. Lack of an embedded proxy server in test_openConnectionLjava_net_Proxy()
> For the first two issues, I'll try to fix it. For the last one, move it into t.a.j.n.ExcludedProxyTest temporarily and enable it when Jetty's Proxy Handler is ready.
> Any comments and suggestions are welcome, thanks a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3422) [classlib][testing]move
tests.api.java.net.URLTest out of the exclude list
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paulex Yang resolved HARMONY-3422.
----------------------------------
Resolution: Fixed
Ruth, patch applied at revision r526667 and r526670, thanks a lot. I suppose it's the right thing to do to remove tests.api.java.net.URLTest from luni/ make/exclude.common, please verify.
> [classlib][testing]move tests.api.java.net.URLTest out of the exclude list
> --------------------------------------------------------------------------
>
> Key: HARMONY-3422
> URL: https://issues.apache.org/jira/browse/HARMONY-3422
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Ruth Cao
> Assigned To: Paulex Yang
> Attachments: Harmony-3422.diff
>
>
> Current t.a.j.n.URLTest has several problems:
> 1. test_URLStreamHandler_parseURL fails since URLStreamHandlerFactory has been already set in the method test_setURLStreamHandlerFactoryLjava_net_URLStreamHandlerFactory()
> 2. Lack of resource jar files and an embedded HTTP server in test_openStream.
> 3. Lack of an embedded proxy server in test_openConnectionLjava_net_Proxy()
> For the first two issues, I'll try to fix it. For the last one, move it into t.a.j.n.ExcludedProxyTest temporarily and enable it when Jetty's Proxy Handler is ready.
> Any comments and suggestions are welcome, thanks a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.