[GitHub] [bahir-flink] eskabetxe commented on a change in pull request #130: [BAHIR-285] flink-connector-redis support SREM command.

[GitBox <gi...@apache.org>]

eskabetxe commented on a change in pull request #130:
URL: https://github.com/apache/bahir-flink/pull/130#discussion_r763840091



##########
File path: .github/workflows/maven-ci.yml
##########
@@ -45,4 +45,4 @@ jobs:
       run: ./dev/change-scala-version.sh ${{ matrix.scala-version }}
       shell: bash
     - name: Build with flink ${{ matrix.flink-version }}
-      run: mvn -B clean verify -Dscala-${{ matrix.scala-version }} -Dflink.version=${{ matrix.flink-version }}

Review comment:
       why?

##########
File path: flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkITCase.java
##########
@@ -77,14 +77,20 @@ public void testRedisListDataType() throws Exception {
     @Test
     public void testRedisSetDataType() throws Exception {
         DataStreamSource<Tuple2<String, String>> source = env.addSource(new TestSourceFunction());
-        RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(jedisPoolConfig,
+        RedisSink<Tuple2<String, String>> redisSaddSink = new RedisSink<>(jedisPoolConfig,
             new RedisCommandMapper(RedisCommand.SADD));
 
-        source.addSink(redisSink);
-        env.execute("Test Redis Set Data Type");
+        source.addSink(redisSaddSink);
+        env.execute("Test SADD");
 
         assertEquals(NUM_ELEMENTS, jedis.scard(REDIS_KEY));
 
+        RedisSink<Tuple2<String, String>> redisSremSink = new RedisSink<>(jedisPoolConfig,

Review comment:
       could we add a new test only to remove?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org