[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #107: [FLINK-27372] Make DataFileMeta and ManifestFileMeta schemaless

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #107:
URL: https://github.com/apache/flink-table-store/pull/107#discussion_r869914759


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/DataFileMetaSerializer.java:
##########
@@ -48,27 +42,25 @@ public RowData toRow(DataFileMeta meta) {
                 StringData.fromString(meta.fileName()),
                 meta.fileSize(),
                 meta.rowCount(),
-                meta.minKey(),
-                meta.maxKey(),
-                keyStatsArraySerializer.toRow(meta.keyStats()),
-                valueStatsArraySerializer.toRow(meta.valueStats()),
+                serializeBinaryRow(meta.minKey()),

Review Comment:
   It is difficult:
   - First, the row serializer is dependent on flink, if we want to have this logic, we need to write a serializer ourselves.
   - Second, avro serialization does not use serializer, it is to get rowData to convert itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org