You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Dean Gaudet <dg...@arctic.org> on 1997/11/21 20:40:01 UTC
[PATCH] mod_status/1448: Status Information should display server version and build date (fwd)
+1
Dean
---------- Forwarded message ----------
Date: 21 Nov 1997 17:26:13 -0000
From: "M.D.Parker" <md...@netcom.com>
To: apbugs@hyperreal.org
Subject: mod_status/1448: Status Information should display server version and build date
>Number: 1448
>Category: mod_status
>Synopsis: Status Information should display server version and build date
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: apache
>State: open
>Class: change-request
>Submitter-Id: apache
>Arrival-Date: Fri Nov 21 09:30:01 PST 1997
>Last-Modified:
>Originator: mdpc@netcom.com
>Organization:
apache
>Release: 1.3b3
>Environment:
N/A
>Description:
In managing a number of different web sites, the status module provides
information to spot problems. However, the different sites run different
versions of the Apache web server which sometimes is confusing to the poor
systems administrator.
With the addition of 2 lines of code, this information is easily provided
in the status display and really does help out.
>How-To-Repeat:
Yes...
>Fix:
*** mod_status.c.dist Thu Nov 20 21:51:15 1997
--- mod_status.c Thu Nov 20 21:56:22 1997
***************
*** 327,332 ****
--- 327,334 ----
rputs("<HTML><HEAD>\n<TITLE>Apache Status</TITLE>\n</HEAD><BODY>\n", r);
rputs("<H1>Apache Server Status for ", r);
rvputs(r, server->server_hostname, "</H1>\n\n", NULL);
+ rvputs(r, "Server Version: ",SERVER_VERSION, "<br>\n", NULL);
+ rvputs(r, "Server Built: ",SERVER_BUILT, "<br>\n", NULL);
rvputs(r, "Current Time: ", asctime(localtime(&nowtime)), "<br>\n", NULL);
rvputs(r, "Restart Time: ", asctime(localtime(&restart_time)), "<br>\n",
NULL);
%0
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <ap...@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED. This is not done]
[automatically because of the potential for mail loops. ]
Re: [PATCH] mod_status/1448: Status Information should display server version and build date (fwd)
Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Fri, Nov 21, 1997 at 11:40:01AM -0800, Dean Gaudet wrote:
> +1
+1. Hasn't this been in there before?
Oh no, but it's already in: mod_info?server
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [PATCH] mod_status/1448: Status Information should display server version and build date (fwd)
Posted by Ben Laurie <be...@algroup.co.uk>.
Alexei Kosut wrote:
>
> On Sat, 22 Nov 1997, Ben Laurie wrote:
>
> > Alexei Kosut wrote:
> > >
> > > On Fri, 21 Nov 1997, Dean Gaudet wrote:
> > >
> > > > + rvputs(r, "Server Version: ",SERVER_VERSION, "<br>\n", NULL);
> > >
> > > This seems to me to have some implicit problems if mod_status is compiled
> > > as a shared library and not a built-in module. In fact, I suspect there
> > > are some similar problems with other information provided by mod_status (I
> > > haven't checked), if the module is used with a different version of Apache
> > > than it is compiled for.
> >
> > Errr ... why?
>
> If the module is compiled under, say, Apache 1.3b7, as a shared library,
> the version, because it's a #define, gets inserted into the mod_status
> library. If I then load this module under Apache 1.3.2, say, and pull up
> the status page, it will still say "Apache/1.3b7", even though I'm now
> running 1.3.2.
>
> That's why.
Ooops, sorry. Brain obviously not fully engaged. I thought we were
talking about SERVER_BUILT.
Cheers,
Ben.
--
Ben Laurie |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant |Fax: +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd, |http://www.algroup.co.uk/Apache-SSL
London, England. |"Apache: TDG" http://www.ora.com/catalog/apache
Re: [PATCH] mod_status/1448: Status Information should display server version and build date (fwd)
Posted by Alexei Kosut <ak...@leland.Stanford.EDU>.
On Sat, 22 Nov 1997, Ben Laurie wrote:
> Alexei Kosut wrote:
> >
> > On Fri, 21 Nov 1997, Dean Gaudet wrote:
> >
> > > + rvputs(r, "Server Version: ",SERVER_VERSION, "<br>\n", NULL);
> >
> > This seems to me to have some implicit problems if mod_status is compiled
> > as a shared library and not a built-in module. In fact, I suspect there
> > are some similar problems with other information provided by mod_status (I
> > haven't checked), if the module is used with a different version of Apache
> > than it is compiled for.
>
> Errr ... why?
If the module is compiled under, say, Apache 1.3b7, as a shared library,
the version, because it's a #define, gets inserted into the mod_status
library. If I then load this module under Apache 1.3.2, say, and pull up
the status page, it will still say "Apache/1.3b7", even though I'm now
running 1.3.2.
That's why.
-- Alexei Kosut <ak...@stanford.edu> <http://www.stanford.edu/~akosut/>
Stanford University, Class of 2001 * Apache <http://www.apache.org> *
Re: [PATCH] mod_status/1448: Status Information should display server version and build date (fwd)
Posted by Ben Laurie <be...@algroup.co.uk>.
Alexei Kosut wrote:
>
> On Fri, 21 Nov 1997, Dean Gaudet wrote:
>
> > + rvputs(r, "Server Version: ",SERVER_VERSION, "<br>\n", NULL);
>
> This seems to me to have some implicit problems if mod_status is compiled
> as a shared library and not a built-in module. In fact, I suspect there
> are some similar problems with other information provided by mod_status (I
> haven't checked), if the module is used with a different version of Apache
> than it is compiled for.
Errr ... why?
Cheers,
Ben.
--
Ben Laurie |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant |Fax: +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd, |http://www.algroup.co.uk/Apache-SSL
London, England. |"Apache: TDG" http://www.ora.com/catalog/apache
Re: [PATCH] mod_status/1448: Status Information should display server version and build date (fwd)
Posted by Alexei Kosut <ak...@leland.Stanford.EDU>.
On Fri, 21 Nov 1997, Dean Gaudet wrote:
> + rvputs(r, "Server Version: ",SERVER_VERSION, "<br>\n", NULL);
This seems to me to have some implicit problems if mod_status is compiled
as a shared library and not a built-in module. In fact, I suspect there
are some similar problems with other information provided by mod_status (I
haven't checked), if the module is used with a different version of Apache
than it is compiled for.
This probably one reason why is SERVER_BUILT is a variable, not a
#define.
-- Alexei Kosut <ak...@stanford.edu> <http://www.stanford.edu/~akosut/>
Stanford University, Class of 2001 * Apache <http://www.apache.org> *