You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Balu Vellanki <bv...@hortonworks.com> on 2015/09/09 20:52:05 UTC
Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/
-----------------------------------------------------------
Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
Bugs: FALCON-1438
https://issues.apache.org/jira/browse/FALCON-1438
Repository: falcon-git
Description
-------
In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
<?xml version="1.0" encoding="UTF-8"?><instancesResult>
<status>FAILED</status>
<message>default/org.apache.falcon.FalconWebException::null
</message>
<requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
</requestId>
</instancesResult>
This should return proper error message.
Diffs
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
Diff: https://reviews.apache.org/r/38230/diff/
Testing
-------
End2End testing done. Added an IT test to catch future regressions.
Thanks,
Balu Vellanki
Re: Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/#review98382
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Sept. 9, 2015, 11:54 p.m., Balu Vellanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38230/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 11:54 p.m.)
>
>
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Bugs: FALCON-1438
> https://issues.apache.org/jira/browse/FALCON-1438
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
>
> <?xml version="1.0" encoding="UTF-8"?><instancesResult>
> <status>FAILED</status>
> <message>default/org.apache.falcon.FalconWebException::null
> </message>
> <requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
> </requestId>
> </instancesResult>
>
>
> This should return proper error message.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
> prism/src/main/java/org/apache/falcon/resource/metadata/AbstractMetadataResource.java e9c90fc
> prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java f8b503a
> prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 23a003a
> prism/src/test/java/org/apache/falcon/resource/metadata/LineageMetadataResourceTest.java ac0e51f
> prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java 14f6e73
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
>
> Diff: https://reviews.apache.org/r/38230/diff/
>
>
> Testing
> -------
>
> End2End testing done. Added an IT test to catch future regressions.
>
>
> Thanks,
>
> Balu Vellanki
>
>
Re: Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/#review98360
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Sept. 9, 2015, 11:54 p.m., Balu Vellanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38230/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 11:54 p.m.)
>
>
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Bugs: FALCON-1438
> https://issues.apache.org/jira/browse/FALCON-1438
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
>
> <?xml version="1.0" encoding="UTF-8"?><instancesResult>
> <status>FAILED</status>
> <message>default/org.apache.falcon.FalconWebException::null
> </message>
> <requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
> </requestId>
> </instancesResult>
>
>
> This should return proper error message.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
> prism/src/main/java/org/apache/falcon/resource/metadata/AbstractMetadataResource.java e9c90fc
> prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java f8b503a
> prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 23a003a
> prism/src/test/java/org/apache/falcon/resource/metadata/LineageMetadataResourceTest.java ac0e51f
> prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java 14f6e73
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
>
> Diff: https://reviews.apache.org/r/38230/diff/
>
>
> Testing
> -------
>
> End2End testing done. Added an IT test to catch future regressions.
>
>
> Thanks,
>
> Balu Vellanki
>
>
Re: Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 11:54 p.m.)
Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
Changes
-------
This change fixes FalconWebException usage in MetadataResource as well.
Bugs: FALCON-1438
https://issues.apache.org/jira/browse/FALCON-1438
Repository: falcon-git
Description
-------
In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
<?xml version="1.0" encoding="UTF-8"?><instancesResult>
<status>FAILED</status>
<message>default/org.apache.falcon.FalconWebException::null
</message>
<requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
</requestId>
</instancesResult>
This should return proper error message.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
prism/src/main/java/org/apache/falcon/resource/metadata/AbstractMetadataResource.java e9c90fc
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java f8b503a
prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 23a003a
prism/src/test/java/org/apache/falcon/resource/metadata/LineageMetadataResourceTest.java ac0e51f
prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java 14f6e73
webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
Diff: https://reviews.apache.org/r/38230/diff/
Testing
-------
End2End testing done. Added an IT test to catch future regressions.
Thanks,
Balu Vellanki
Re: Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
Posted by Balu Vellanki <bv...@hortonworks.com>.
> On Sept. 9, 2015, 9:27 p.m., Sowmya Ramesh wrote:
> > Can we look at other code paths where WebApplicationException is called/thrown to make sure null message is not thrown?
Very good point Sowmya Ramesh. I looked at other resources and found that MetadatResource is using FalconWebApplication incorrectly. I fixed this and submitted a new patch for review. I updated the tests as well. Please review.
- Balu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/#review98273
-----------------------------------------------------------
On Sept. 9, 2015, 6:52 p.m., Balu Vellanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38230/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 6:52 p.m.)
>
>
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Bugs: FALCON-1438
> https://issues.apache.org/jira/browse/FALCON-1438
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
>
> <?xml version="1.0" encoding="UTF-8"?><instancesResult>
> <status>FAILED</status>
> <message>default/org.apache.falcon.FalconWebException::null
> </message>
> <requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
> </requestId>
> </instancesResult>
>
>
> This should return proper error message.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
>
> Diff: https://reviews.apache.org/r/38230/diff/
>
>
> Testing
> -------
>
> End2End testing done. Added an IT test to catch future regressions.
>
>
> Thanks,
>
> Balu Vellanki
>
>
Re: Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
Posted by Balu Vellanki <bv...@hortonworks.com>.
> On Sept. 9, 2015, 9:27 p.m., Sowmya Ramesh wrote:
> > Can we look at other code paths where WebApplicationException is called/thrown to make sure null message is not thrown?
>
> Balu Vellanki wrote:
> Very good point Sowmya Ramesh. I looked at other resources and found that MetadatResource is using FalconWebApplication incorrectly. I fixed this and submitted a new patch for review. I updated the tests as well. Please review.
correction : FalconWebException
- Balu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/#review98273
-----------------------------------------------------------
On Sept. 9, 2015, 11:54 p.m., Balu Vellanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38230/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 11:54 p.m.)
>
>
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Bugs: FALCON-1438
> https://issues.apache.org/jira/browse/FALCON-1438
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
>
> <?xml version="1.0" encoding="UTF-8"?><instancesResult>
> <status>FAILED</status>
> <message>default/org.apache.falcon.FalconWebException::null
> </message>
> <requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
> </requestId>
> </instancesResult>
>
>
> This should return proper error message.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
> prism/src/main/java/org/apache/falcon/resource/metadata/AbstractMetadataResource.java e9c90fc
> prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java f8b503a
> prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 23a003a
> prism/src/test/java/org/apache/falcon/resource/metadata/LineageMetadataResourceTest.java ac0e51f
> prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java 14f6e73
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
>
> Diff: https://reviews.apache.org/r/38230/diff/
>
>
> Testing
> -------
>
> End2End testing done. Added an IT test to catch future regressions.
>
>
> Thanks,
>
> Balu Vellanki
>
>
Re: Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/#review98273
-----------------------------------------------------------
Can we look at other code paths where WebApplicationException is called/thrown to make sure null message is not thrown?
- Sowmya Ramesh
On Sept. 9, 2015, 6:52 p.m., Balu Vellanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38230/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 6:52 p.m.)
>
>
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Bugs: FALCON-1438
> https://issues.apache.org/jira/browse/FALCON-1438
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
>
> <?xml version="1.0" encoding="UTF-8"?><instancesResult>
> <status>FAILED</status>
> <message>default/org.apache.falcon.FalconWebException::null
> </message>
> <requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
> </requestId>
> </instancesResult>
>
>
> This should return proper error message.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
>
> Diff: https://reviews.apache.org/r/38230/diff/
>
>
> Testing
> -------
>
> End2End testing done. Added an IT test to catch future regressions.
>
>
> Thanks,
>
> Balu Vellanki
>
>
Re: Review Request 38230: Falcon RestAPI - In case of error falcon
responds with FalconWebException::null
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/#review98242
-----------------------------------------------------------
The root cause of the issue was that the method
{code}
public static FalconWebException newInstanceException(Throwable e, Response.Status status)
{code}
is returning
{code}
public FalconWebException(Response response) {
super(response);
}
{code}
The super(response) here is WebApplicationException(Response response), which in turn calls WebApplicationException(null, response). This is where the "null" message is coming from. To fix this error, FalconWebException should call super(Throwable e, Response response) instead.
- Balu Vellanki
On Sept. 9, 2015, 6:52 p.m., Balu Vellanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38230/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 6:52 p.m.)
>
>
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Bugs: FALCON-1438
> https://issues.apache.org/jira/browse/FALCON-1438
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and getting a response:
>
> <?xml version="1.0" encoding="UTF-8"?><instancesResult>
> <status>FAILED</status>
> <message>default/org.apache.falcon.FalconWebException::null
> </message>
> <requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
> </requestId>
> </instancesResult>
>
>
> This should return proper error message.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e
>
> Diff: https://reviews.apache.org/r/38230/diff/
>
>
> Testing
> -------
>
> End2End testing done. Added an IT test to catch future regressions.
>
>
> Thanks,
>
> Balu Vellanki
>
>